search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.57k stars 2.91k forks source link

Force correct type for TrynewDot NVP classicRedirect.dismissed #52892

Open Julesssss opened 17 hours ago

Julesssss commented 17 hours ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Problem

Our backend requires that the TryNewDot NVP value of classicRedirect.dismissed is always a bool. The App client suggests that a string can be used in TryNewDot.ts, which has led to bugs and confusion.

Also, we need to fix cases where a string might be being set. For example, the 'Try New Expensify' button.

Solution

Force the type to be bool here

View all open jobs on GitHub

Julesssss commented 17 hours ago

This is being handled by me and @war-in as a solution to a problem we faced here.

war-in commented 17 hours ago

Hi, I'm Marcin from Software Mansion and I'm going to work on that issue :)