Closed mjasikowski closed 3 days ago
@deetergp Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and not onIconClick
).src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components using Avatar
have been tested & I retested again)/** comment above it */
this
properly so there are no scoping issues (i.e. for onClick={this.submit}
the method this.submit
should be bound to this
in the constructor)this
are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this);
if this.submit
is never passed to a component event handler like onClick
)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG
)Avatar
is modified, I verified that Avatar
is working as expected in all cases)Design
label and/or tagged @Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test
steps.@mjasikowski looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency
label if this is not an emergency.
Not an emergency, skipped checklists because this is a straight revert for a deploy blocker.
:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.
π Cherry-picked to staging by https://github.com/mountiny in version: 9.0.65-3 π
platform | result |
---|---|
π€ android π€ | success β |
π₯ desktop π₯ | success β |
π iOS π | success β |
πΈ web πΈ | success β |
π€π android HybridApp π€π | success β |
ππ iOS HybridApp ππ | success β |
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.
π Deployed to production by https://github.com/chiragsalian in version: 9.0.65-5 π
platform | result |
---|---|
π€ android π€ | success β |
π₯ desktop π₯ | success β |
π iOS π | success β |
πΈ web πΈ | success β |
π€π android HybridApp π€π | failure β |
ππ iOS HybridApp ππ | failure β |
Reverts Expensify/App#50387 to fix https://github.com/Expensify/App/issues/52873
Straight revert.