Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.57k stars 2.91k forks source link

[$250] Take a 2-minute tour task not displayed in concierge #52908

Open m-natarajan opened 15 hours ago

m-natarajan commented 15 hours ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.64-4 Reproducible in staging?: Y Reproducible in production?: Y If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @danielrvidal Slack conversation (hyperlinked to channel name): ts_external_expensify_convert

Action Performed:

  1. Go to staging.new.expensify.com
  2. Signup for new account (use a non gmail account like - abc@defg123.com
  3. Choose Track and budget expenses and continue

    Expected Result:

    Take a 2-minute tour task displayed in concierge

    Actual Result:

    Take a 2-minute tour task not displayed in concierge

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

image (12)

https://github.com/user-attachments/assets/f1329ea2-e33c-45b9-be3b-cec11ebb393b

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021859657220522969112
  • Upwork Job ID: 1859657220522969112
  • Last Price Increase: 2024-11-21
Issue OwnerCurrent Issue Owner: @
Issue OwnerCurrent Issue Owner: @rushatgabhane
melvin-bot[bot] commented 15 hours ago

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

rushatgabhane commented 15 hours ago

looking like a backend bug to me 🎀 👀 🎀

melvin-bot[bot] commented 15 hours ago

Triggered auto assignment to @rafecolton, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

sonialiap commented 15 hours ago

@rafecolton do you think this is BE or FE?

rushatgabhane commented 15 hours ago

sorry this might be frontend @c3024 clarified. they'll also raise a PR

rafecolton commented 13 hours ago

So what's the right way to get this assigned to everybody? Do I assign you both manually?

c3024 commented 13 hours ago

Yes, I think that is the way.

rafecolton commented 12 hours ago

mando-way-this-is-the-way

melvin-bot[bot] commented 11 hours ago

Job added to Upwork: https://www.upwork.com/jobs/~021859657220522969112

melvin-bot[bot] commented 11 hours ago

Current assignees @rushatgabhane and @c3024 are eligible for the External assigner, not assigning anyone new.

sonialiap commented 11 hours ago

Nice, adding the labels 💃

Anaslancer commented 8 hours ago

Proposal

Please re-state the problem that we are trying to solve in this issue.

Take a 2-minute tour task not displayed in concierge

What is the root cause of that problem?

After sign up, the backend returns accountID, ie: 18723350, 18723351 SignUpUser_api if accountID is an even value, we are missing Take a 2-minute tour task according to the current logic. https://github.com/Expensify/App/blob/93f7874ddc9258d7481b1f2257a80c66c8d283dc/src/libs/actions/Report.ts#L3482-L3492 https://github.com/Expensify/App/blob/93f7874ddc9258d7481b1f2257a80c66c8d283dc/src/libs/Permissions.ts#L32-L36 https://github.com/Expensify/App/blob/93f7874ddc9258d7481b1f2257a80c66c8d283dc/src/libs/Permissions.ts#L6 https://github.com/Expensify/App/blob/93f7874ddc9258d7481b1f2257a80c66c8d283dc/src/CONST.ts#L212-L233

What changes do you think we should make in order to solve the problem?

If we should show Take a 2-minute tour task for all users, we should add this task at here. https://github.com/Expensify/App/blob/93f7874ddc9258d7481b1f2257a80c66c8d283dc/src/CONST.ts#L5176

        [combinedTrackSubmitOnboardingChoices.PERSONAL_SPEND]: {
            ...combinedTrackSubmitOnboardingPersonalSpendMessage,
            tasks: [selfGuidedTourTask, ...combinedTrackSubmitOnboardingPersonalSpendMessage.tasks],
        },

What alternative solutions did you explore? (Optional)

Contributor details

Your Expensify account email: anasup1995@gmail.com Upwork Profile Link: https://www.upwork.com/freelancers/~01aff093c9a804b145

melvin-bot[bot] commented 8 hours ago

✅ Contributor details stored successfully. Thank you for contributing to Expensify!