[$250] In Search LHN, only saved search area is scrollable rather than the whole LHN being scrollable

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.64-4 Reproducible in staging?: Y Reproducible in production?: Y If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @shawnborton Slack conversation (hyperlinked to channel name): ts_external_expensify_expense

Action Performed:

Prerequisite: User have more than 4 saved searches

1. Click Search
2. Scroll the LHN

   Expected Result:

   The whole LHN scrolls just like it does in Settings

   Actual Result:

   Only saved search area is scrollable

   Workaround:

   Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [ ] Android: Standalone
• [ ] Android: HybridApp
• [ ] Android: mWeb Chrome
• [ ] iOS: Standalone
• [ ] iOS: HybridApp
• [ ] iOS: mWeb Safari
• [x] MacOS: Chrome / Safari
• [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/b6578320-8678-4f5b-8dc7-61824a5f15ae

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021859709289451685912
• Upwork Job ID: 1859709289451685912
• Last Price Increase: 2024-11-21

Issue Owner

Current Issue Owner: @allgandalf

[melvin-bot[bot]]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[FitseTLT]

Might be intentional we want the search types to always be visible

[shawnborton]

This is a bug, we want the whole area to be scrollable like we have on Settings.

[bernhardoj]

Edited by proposal-police: This proposal was edited at 2024-11-21 14:42:08 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

In search LHN, only the saved search is scrollable.

What is the root cause of that problem?

Currently, we only wrap the saved search list with a scroll view, so it's only the saved search that is scrollable. https://github.com/Expensify/App/blob/4c44827398f884af626872c33f64dd358d19eff4/src/pages/Search/SearchTypeMenu.tsx#L275-L280

What changes do you think we should make in order to solve the problem?

Wrap the whole search type menu (for non-narrow layout) in scroll view instead and remove the scroll view from the saved searches. https://github.com/Expensify/App/blob/4c44827398f884af626872c33f64dd358d19eff4/src/pages/Search/SearchTypeMenu.tsx#L246-L284

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~021859709289451685912

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allgandalf (External)