Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.57k stars 2.91k forks source link

Add selfGuidedTour task to trackAndSubmit beta enabled users #52912

Open c3024 opened 15 hours ago

c3024 commented 15 hours ago

Explanation of Change

This PR adds self guided tour task to trackAndSubmit beta enabled users.

Fixed Issues

$ https://github.com/Expensify/App/issues/52908 PROPOSAL: https://expensify.slack.com/archives/C07HPDRELLD/p1732198981416579?thread_ts=1731371352.606329&cid=C07HPDRELLD

Tests

  1. Set the canUseCombinedTrackSubmit beta as true in Permissions.ts.
  2. Logon to new dot with a new account.
  3. Select the first onboarding choice and complete the onboarding flow.
  4. Verify that the "Take 2 minute tour" task shows up in Concierge chat.
  5. Repeat step 2 to 4 for all choices.
  6. Verify that the "Take 2 minute tour" task shows up in Concierge chat for all choices except "Something else"
  7. Set the canUseCombinedTrackSubmit beta as false in Permissions.ts.
  8. Repeat steps 2 to 6 and verify the same result as in step 6.

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

  1. Logon to new dot with a new account.
  2. Check if the account id for this account is even. (Settings > Profile > Share > Copy URL > Check the number in the link)
  3. If it is not even, repeat step 1 and 2 until you get an even number.
  4. Select the first onboarding choice and complete the onboarding flow.
  5. Verify that the "Take 2 minute tour" task shows up in Concierge chat.
  6. Repeat step 1 to 4 for all choices.
  7. Verify that the "Take 2 minute tour" task shows up in Concierge chat for all choices except "Something else".
  8. Repeat all steps for an account with odd number account id and verify the same result as in Step 7.

PR Author Checklist

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari https://github.com/user-attachments/assets/c2579971-7883-49fe-8565-524ebf92476c
MacOS: Desktop
melvin-bot[bot] commented 15 hours ago

@getusha Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

c3024 commented 15 hours ago

@getusha, sorry for the ping.

@rushatgabhane will review this.