Open marcochavezf opened 11 hours ago
@thienlnam Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]
Adding Jules here, I'm not that familiar with these so want a second pair of eyes on this
https://github.com/user-attachments/assets/c4ab0926-1921-40e8-bde2-e5ea9f7409b8
BUG: Going to settings/subscription/add-payment-card
is giving not found error.
I will mark the PR as WIP, since the new Android deep link configuration is not working as expected
I will mark the PR as WIP, since the new Android deep link configuration is not working as expected
Not working for iOS as well
Maybe AdHoc build is required to test this.
Explanation of Change
Coming from this internal discussion, we want to blacklist the deep link for
Add payment card
page so we can always redirect to web/mWebFixed Issues
$ PROPOSAL:
Tests
Run the following scripts and verify the
Add payment card
is not opened in the appRun the following scripts and verify the
Settings
page is opened in the appOffline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop