Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.57k stars 2.91k forks source link

[WIP] Exclude add payment card deep link #52925

Open marcochavezf opened 11 hours ago

marcochavezf commented 11 hours ago

Explanation of Change

Coming from this internal discussion, we want to blacklist the deep link for Add payment card page so we can always redirect to web/mWeb

Fixed Issues

$ PROPOSAL:

Tests

Run the following scripts and verify the Add payment card is not opened in the app

npx uri-scheme open new-expensify://settings/subscription/add-payment-card  --ios
npx uri-scheme open new-expensify://settings/subscription/add-payment-card  --android

Run the following scripts and verify the Settings page is opened in the app

npx uri-scheme open new-expensify://settings --ios
npx uri-scheme open new-expensify://settings --android

Offline tests

QA Steps

  1. Open the following link new.expensify.com/settings/subscription/add-payment-card from an iOS and Android device and verify you're redirected to web instead of opening the page directly in the app
  2. Open new.expensify.com/settings and verify you're redirected to the settings page in the app on both iOS and Android

PR Author Checklist

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop
melvin-bot[bot] commented 11 hours ago

@thienlnam Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

thienlnam commented 11 hours ago

Adding Jules here, I'm not that familiar with these so want a second pair of eyes on this

shubham1206agra commented 10 hours ago

https://github.com/user-attachments/assets/c4ab0926-1921-40e8-bde2-e5ea9f7409b8

BUG: Going to settings/subscription/add-payment-card is giving not found error.

marcochavezf commented 4 hours ago

I will mark the PR as WIP, since the new Android deep link configuration is not working as expected

shubham1206agra commented 41 minutes ago

I will mark the PR as WIP, since the new Android deep link configuration is not working as expected

Not working for iOS as well

shubham1206agra commented 40 minutes ago

Maybe AdHoc build is required to test this.