Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.57k stars 2.91k forks source link

Update Pullerbear to assign Concierge reviewer to HelpDot PRs #52930

Open stephanieelliott opened 3 days ago

stephanieelliott commented 3 days ago

Problem:

HelpDot PRs are often approved despite not meeting our internal quality standards for helpsite articles.

Solution

Assign a Concierge team member to review all HelpDot PRs prior to engineering review.

Context:

See this Slack conversation: https://expensify.slack.com/archives/GP2FVSJ7Q/p1732197881553919?thread_ts=1732056046.254649&cid=GP2FVSJ7Q


Function:

When an App PR with changes to the docs is assigned to PullerBear for review, in addition to the assigned engineer, assign someone from concierge. Then comment on the issue with Concierge reviewer checklist.

Concierge reviewer checklist:

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

melvin-bot[bot] commented 3 days ago

Triggered auto assignment to @mallenexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

melvin-bot[bot] commented 3 days ago

:warning: It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time :warning:

melvin-bot[bot] commented 3 days ago

Triggered auto assignment to Design team member for new feature review - @shawnborton (NewFeature)

rafecolton commented 3 days ago

Oh interesting, I didn't realize that label assigned design - Shawn, you can disregard

rafecolton commented 3 days ago

Wow that NewFeature label is aggressive 😅