Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.57k stars 2.91k forks source link

Cleanup errors for Google Tag Manager #52934

Open arosiclair opened 9 hours ago

arosiclair commented 9 hours ago

Explanation of Change

Fixes the MIME type and path for our thirdPartyScripts.js link

Fixed Issues

$ https://github.com/Expensify/App/issues/52922

Tests

Note: web test only

  1. Open developer console and enable Preserve log
  1. Sign out of NewDot
  2. Refresh the page
  3. Sign in
  4. Open any chat
  5. Refresh the page again
  6. Verify
    • There is no error Refused to execute script from 'https://new.expensify.com/r/thirdPartyScripts.js'...
    • There is a thirdPartyScripts.js loaded log

Offline tests

None

QA Steps

Same as Tests

PR Author Checklist

Screenshots/Videos

MacOS: Chrome / Safari ![Screenshot 2024-11-21 at 5 12 40 PM](https://github.com/user-attachments/assets/4ad9e178-e777-44f5-be90-7e43f082ff1c)
melvin-bot[bot] commented 8 hours ago

@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]