search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.57k stars 2.91k forks source link

Start creating optimistic transactionThreadReportID and createdReportActionIDForThread and passing it in HoldRequest #52935

Open iwiznia opened 8 hours ago

iwiznia commented 8 hours ago

We are about to change some of our backend code to not create the transaction thread reports when we create a new money request.

In order to do that, we need to ensure that on the action IOU.putOnHold, we start creating the data for the transaction thread report and its created action optimistically (if the data does not exist yet), the same way we do it for the requestMoney action and pass the transactionThreadReportID and createdReportActionIDForThread to the API request.

I also see that the API.write call for putOnHold is not using the HOLD_MONEY_REQUEST constant, so let's fix that too.

Issue OwnerCurrent Issue Owner: @parasharrajat
melvin-bot[bot] commented 8 hours ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)