Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.55k stars 2.9k forks source link

Unable to complete the Onfido check on Android browsers #5299

Open Julesssss opened 3 years ago

Julesssss commented 3 years ago

CC @MitchExpensify


NOTE: We have recent reports with more info (for example, using the Brave browser), please can these be read before testing, thanks!

Action Performed:

User report:

Trying to use onfido to verify identity and Camera and Microphone are fully allowed in browser and in device settings. Every time I click Enable Both for Allow Camera and Microphone Access, it pops up with Camera and microphone access denied. Tried with 3 browsers (Firefox Beta, Chrome, Samsung Browser) on Pixel 8 Pro running Android 14.

Expected Result:

Actual Result:

https://user-images.githubusercontent.com/10736861/134701301-4074f2a2-2c42-4c97-82ea-34bbf691bbd9.mp4

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Users cannot add bank accounts for payment

Platform:

Where is this issue occurring?

Version Number: Reproducible in staging?: Yes Reproducible in production?: N/A Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: See above Expensify/Expensify Issue URL: N/A Issue reported by: @Julesssss Slack conversation: https://expensify.slack.com/archives/C020EPP9B9A/p1631806430343700?thread_ts=1631803999.337800&cid=C020EPP9B9A

MelvinBot commented 3 years ago

Triggered auto assignment to @mateocole (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

Julesssss commented 3 years ago

This is on Onfido's side, I think we need to confirm, then reach out to them and raise a bug.

Julesssss commented 3 years ago

CC @kevinksullivan, maybe I should have created this as an Internal issue?

Julesssss commented 3 years ago

The Onfido SDK doesn't have any issues which match my bug, so I'm going to record the failure and open a new issue.

MelvinBot commented 3 years ago

@Julesssss, @mateocole Whoops! This issue is 2 days overdue. Let's get this updated quick!

mateocole commented 3 years ago

@Julesssss would this issue be used to track the status and update info as we receive it from Onfido? Or, is there actions a member of engineering should be assigned to this to follow up on?

Julesssss commented 3 years ago

Hey @mateocole, we can use this issue to track internally -- I'll update this manually.

mateocole commented 3 years ago

Okay sounds good!

Julesssss commented 3 years ago

Onfido Issue. Awaiting response from the Onfido team.

ctkochan22 commented 3 years ago

@Julesssss can you test if you are able to complete this via the old dot way.

  1. Go to payments on old dot
  2. Create a verified BBA
  3. Go to onfido
  4. Scan the QR code
Julesssss commented 3 years ago

Good idea @ctkochan22.

I can confirm that I'm seeing the same issue here, which means this shouldn't be considered a blocker.

Julesssss commented 3 years ago

Separately, I have been able to verify that the mWeb/QR code flow works on an older Android device (Nexus 5X) using Chrome. Something about my Pixel 2's configuration must be causing this issue, odd.

ctkochan22 commented 3 years ago

This is on staging or prod? I can fire up my dev to check it out

Julesssss commented 3 years ago

It occurs in all environments, and I don't think it's a bug in our implementation. It's the id.onfido.com webpage that is launched via a QR code if you attempt to add a card on web. When I switch to Android I'm stuck in this permission loop.

Julesssss commented 3 years ago

This seems to be a rare issue, so I'm reducing the priority.

Julesssss commented 3 years ago

Never heard back from Onfido. I'm going to close this as it's not on our side, and a rare issue.

AluminumHaste commented 1 month ago

This is STILL broken on Android. Trying to use onfido to verify identity and Camera and Microphone are fully allowed in browser and in device settings. Every time I click Enable Both for Allow Camera and Microphone Access, it pops up with Camera and microphone access denied.

Tried with 3 browsers (Firefox Beta, Chrome, Samsung Browser) on Pixel 8 Pro running Android 14.

melvin-bot[bot] commented 1 month ago

📣 @AluminumHaste! 📣 Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork. Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details. Screen Shot 2022-11-16 at 4 42 54 PM Format:
    Contributor details
    Your Expensify account email: <REPLACE EMAIL HERE>
    Upwork Profile Link: <REPLACE LINK HERE>
Julesssss commented 1 month ago

Hi @AluminumHaste, thanks for sharing. Lets see if QA are able to reproduce.

Julesssss commented 1 month ago

Waiting on retest

Julesssss commented 1 month ago

Waiting for retest

dangerweenie commented 3 weeks ago

also happening on brave browser for Android - camera is enabled in brave app permissions as well as in "site settings", but I am not getting any pop-up or prompt - it's just saying camera access is not allowed.

melvin-bot[bot] commented 3 weeks ago

📣 @dangerweenie! 📣 Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork. Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details. Screen Shot 2022-11-16 at 4 42 54 PM Format:
    Contributor details
    Your Expensify account email: <REPLACE EMAIL HERE>
    Upwork Profile Link: <REPLACE LINK HERE>
kavimuru commented 3 weeks ago

Issue not reproducible

https://github.com/user-attachments/assets/63ff91d2-c3a0-4f7a-9594-288266dd9461

Julesssss commented 2 weeks ago

For the next retest, would it be possible to retest this issue on the Android Brave browser, please? It sounds like customers can reproduce in certain circumstances

Julesssss commented 3 days ago

Awaiting retest