Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.58k stars 2.92k forks source link

Hybrid - Android - App crashes on tapping "Domains" in settings page #52998

Open IuliiaHerets opened 4 days ago

IuliiaHerets commented 4 days ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: V9. 0.66-0 Reproducible in staging?: N Reproducible in production?: N If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y Issue reported by: Applause Internal Team

Action Performed:

  1. Launch app
  2. Tap settings
  3. Tap Domains

Expected Result:

App must not crash on tapping "Domains" in settings page.

Actual Result:

App crashes on tapping "Domains" in settings page.

Workaround:

Unknown

Platforms:

Screenshots/Videos

2311.txt

https://github.com/user-attachments/assets/4ab0aeed-f476-4e55-9c63-89e9a0255f1e

View all open jobs on GitHub

melvin-bot[bot] commented 4 days ago

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] commented 4 days ago

Triggered auto assignment to @youssef-lr (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

melvin-bot[bot] commented 4 days ago

💬 A slack conversation has been started in #expensify-open-source

github-actions[bot] commented 4 days ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
mountiny commented 2 days ago

I am not sure if this is hybrid app related, this button just opens the page in a browser

youssef-lr commented 2 days ago

I couldn't reproduce this one in Browserstack @mountiny

mountiny commented 2 days ago

Redmi note 10s Android 13 was the device used

mountiny commented 2 days ago

This is the exception for this case

Fatal Exception: com.facebook.react.common.JavascriptException: Error: TaskQueue: Error with task : [Pusher] instance not found. Pusher.subscribe()
            most likely has been called before Pusher.init(), js engine: hermes, stack:
anonymous@1:3789481
processNext@1:846927
_processUpdate@1:845633
anonymous@1:524029
_callTimer@1:522946
_callReactNativeMicrotasksPass@1:523147
callReactNativeMicrotasks@1:525099
__callReactNativeMicrotasks@1:217573
anonymous@1:215773
__guard@1:217447
flushedQueue@1:215684
callFunctionReturnFlushedQueue@1:215540

       at com.facebook.react.modules.core.ExceptionsManagerModule.reportException(ExceptionsManagerModule.java:65)
       at com.facebook.jni.NativeRunnable.run(NativeRunnable.java)
       at android.os.Handler.handleCallback(Handler.java:942)
       at android.os.Handler.dispatchMessage(Handler.java:99)
       at com.facebook.react.bridge.queue.MessageQueueThreadHandler.dispatchMessage(MessageQueueThreadHandler.java:27)
       at android.os.Looper.loopOnce(Looper.java:211)
       at android.os.Looper.loop(Looper.java:300)
       at com.facebook.react.bridge.queue.MessageQueueThreadImpl$4.run(MessageQueueThreadImpl.java:235)
       at java.lang.Thread.run(Thread.java:1012)
mountiny commented 2 days ago

@war-in @youssef-lr were not able to reproduce, same as on ios where the link opens in safari.

Going to demote for now, but lets keep this open as we are discussing some changes in the deeplinks logic in hybrid app

CortneyOfstad commented 1 day ago

Sounds good — thanks @mountiny!

mountiny commented 1 day ago

I believe this might have been fixed now, feel free to ask for a retest and close