Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.57k stars 2.91k forks source link

Search - No approve button on the transaction in search page #53018

Open lanitochka17 opened 1 day ago

lanitochka17 commented 1 day ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.66-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers): applausetester+nl805@applause.expensifail.com Issue reported by: Applause - Internal Team

Issue found when executing PR https://github.com/Expensify/App/pull/52441

Action Performed:

Pre conditions: Make sure you have a report that can be approved, i.e. create a workspace, invite a member, turn on approvals and reimbursement (workflows), as the member submit a few expenses

  1. As the admin open the expenses submitted and observe the approve button appears
  2. Navigate to search page

Expected Result:

Approve button appears next to the expense/report

Actual Result:

No approve buttons are appearing next to the expense/report

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/bb2d724a-f369-4f20-b89f-6a143e4ac841

View all open jobs on GitHub

melvin-bot[bot] commented 1 day ago

Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

abzokhattab commented 1 day ago

not able to reproduce:

image
cretadn22 commented 1 day ago

@luacmartins

This is a BE bug. The BE returns a incorrect value for the isFromOneTransactionReport field

https://github.com/Expensify/App/blob/3ebe8520d74c57a2fe9548b7d4307206e2b7c673/src/libs/SearchUIUtils.ts#L269-L271

As a result, this condition is met, and the View action is displayed.