Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.58k stars 2.92k forks source link

Adding bank account to receive invoice payment is confusing #53032

Open m-natarajan opened 3 days ago

m-natarajan commented 3 days ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.66-0 Reproducible in staging?: y Reproducible in production?: y If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @neil-marcellini Slack conversation (hyperlinked to channel name): Expensify-billpay

Action Performed:

  1. Go to staging.new.expensify.com
  2. Create a workspace if needed
  3. Go to More features, scroll down and enable Invoices
  4. Click green plus, Send invoice
  5. [User A] Send an invoice to User B
  6. [User B] Go to invoice chat and pay the invoice as business
  7. [User A] Go to invoice report
  8. [User A] Click Add bank account
  9. [User A] Note that the button leads to Invoices on workspace settings
  10. [User A] Click Add bank account and add a bank account
  11. [User A] Go back to workspace chat

    Expected Result:

    After adding a bank account for the invoice report the user should be navigated back to it, and the add bank account button should be gone. We could potentially have a system message saying that they added a bank account to receive the invoice payment. Also, maybe instead of directing the the workspace settings after clicking add bank account, we should instead have an informational page at the end of the flow in the RHP that explains the account has been added as the invoice transfer bank account.

    Actual Result:

    The add bank account button on the invoice report navigates to settings, then after adding it you land back on the settings page and have to manually navigate back to the invoice report. Additionally, the add bank account button will remain present until you go to invoicing settings, click on the overflow menu of the bank account, and make it the default payment method.

    Workaround:

    unknown

    Platforms:

    Which of our officially supported platforms is this issue occurring on?

    • [ ] Android: Standalone
    • [ ] Android: HybridApp
    • [ ] Android: mWeb Chrome
    • [ ] iOS: Standalone
    • [ ] iOS: HybridApp
    • [ ] iOS: mWeb Safari
    • [x] MacOS: Chrome / Safari
    • [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/ec372a3a-121c-4bdb-9916-7b1627f7e600

View all open jobs on GitHub

melvin-bot[bot] commented 3 days ago

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] commented 3 days ago

Triggered auto assignment to @arosiclair (AutoAssignerNewDotQuality)

MelvinBot commented 3 days ago

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

abzokhattab commented 3 days ago

I think this is a dupe of https://github.com/Expensify/App/issues/50474

arosiclair commented 1 day ago

Unassigning since this isn't a quality issue

johncschuster commented 1 day ago

Agreed. I think this fits into #expense better. I also think this behavior is expected. I've raised a discussion here to chat about it.

johncschuster commented 20 hours ago

Discussion is ongoing