Categories - App back button returns to the same page after clicking back button on Import RHP

IuliiaHerets commented 2 hours ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.66-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y Email or phone of affected tester (no customers): applausetester+283911@applause.expensifail.com Issue reported by: Applause Internal Team

Action Performed:

Go to staging.new.expensify.com
Go to workspace settings.
Click app back button on the top left.
Note that one click on the back button returns to workspace list.
Go to workspace settings > Categories.
Click 3-dot menu > Import spreadsheet.
Click RHP back button to dismiss the RHP (important).
Click app back button on the top left.

Expected Result:

App will return to the workspace list.

Actual Result:

App remains on the same page. Only the second click on the app back button will return it to workspace list.

Workaround:

Unknown

Platforms:

[x] Android: Standalone
[x] Android: HybridApp
[x] Android: mWeb Chrome
[x] iOS: Standalone
[x] iOS: HybridApp
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos

https://github.com/user-attachments/assets/a26e67eb-1971-4e1b-83aa-e1c94bfd57ee

View all open jobs on GitHub

melvin-bot[bot] commented 2 hours ago

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

abzokhattab commented 1 hour ago

Proposal

Please re-state the problem that we are trying to solve in this issue.

App back button returns to the same page after clicking back button on Import RHP

What is the root cause of that problem?

Clicking the "Import Spreadsheet" button navigates to the spreadsheet component and passes the backTo parameter as the current route (category page).
This adds the current route (category page) to the navigation history again, leading to duplication when going back in the category page https://github.com/Expensify/App/blob/809ee8c277f6f241734b8e9d8dd5ddcfcc17879d/src/pages/workspace/categories/ImportCategoriesPage.tsx#L33-L36 https://github.com/Expensify/App/blob/8d3f1db0ef1b28c5ef9c03f251d9b9dc2adaed4e/src/components/ImportSpreadsheet.tsx#L170
instead we shouldn't provide a fallback value if the isQuickSettingsFlow is false here

What changes do you think we should make in order to solve the problem?

we should set the back to param as an empty string or undefined if the isQuickSettingsFlow is false here so that it doesnt navigate to the categories page instead it just goes back
```
            backTo={isQuickSettingsFlow ? ROUTES.SETTINGS_CATEGORIES_ROOT.getRoute(policyID, backTo) : ''}
```
same should be done in other places that use the ImportSpreedsheet to avoid the double navigation (here and here )
this is simlier to the WorkspaceInvitePage where we just go back without providing a fallback route in this case.

POC

https://github.com/user-attachments/assets/32f7ff62-c7f0-4dc7-a3f8-d7a54fa60d81

Expensify / App