Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.58k stars 2.92k forks source link

[$250] No input autofocus when connecting Sage Intacct. #53156

Open m-natarajan opened 3 days ago

m-natarajan commented 3 days ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.67-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @suneox Slack conversation (hyperlinked to channel name): ts_external_expensify_bugs

Action Performed:

  1. Open the app and log in
  2. Create a workspace if there is no any
  3. Navigate to the workspace settings > More features and enable the Accounting option
  4. Open Accounting and select Intacct
  5. Upgrade the policy if it has not been done yet
  6. Next to the step to enter credentials

    Expected Result:

    The first input field should automatically focus

    Actual Result:

    No input field is focused.

    Workaround:

    Unknown

    Platforms:

    Which of our officially supported platforms is this issue occurring on?

    • [x] Android: Standalone
    • [x] Android: HybridApp
    • [ ] Android: mWeb Chrome
    • [ ] iOS: Standalone
    • [ ] iOS: HybridApp
    • [ ] iOS: mWeb Safari
    • [x] MacOS: Chrome / Safari
    • [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/3756ef6c-446d-4421-914f-304ababa49b8

https://github.com/user-attachments/assets/42f6262e-1096-44f5-878a-6cc8da49d391

https://github.com/user-attachments/assets/59d8f9dc-e3c2-4d89-91a7-f40e0a442bf0

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021861840903242082245
  • Upwork Job ID: 1861840903242082245
  • Last Price Increase: 2024-11-27
Issue OwnerCurrent Issue Owner: @thesahindia
melvin-bot[bot] commented 3 days ago

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

nkdengineer commented 3 days ago

Proposal

Please re-state the problem that we are trying to solve in this issue.

No input autofocus when connecting Sage Intacct.

What is the root cause of that problem?

We are not using useAutoFocusInput in this inputs

https://github.com/Expensify/App/blob/afad1ac23236ecd101c33f909087cb7edd43288f/src/pages/workspace/accounting/intacct/EnterSageIntacctCredentialsPage.tsx#L78-L85

What changes do you think we should make in order to solve the problem?

We can do the same way as we did here

    const {inputCallbackRef} = useAutoFocusInput();

    <InputWrapper
       ...
       ref={index === 0 ? inputCallbackRef : undefined}
     >

https://github.com/Expensify/App/blob/afad1ac23236ecd101c33f909087cb7edd43288f/src/pages/workspace/accounting/intacct/EnterSageIntacctCredentialsPage.tsx#L78-L85

What alternative solutions did you explore? (Optional)

NA

suneox commented 3 days ago

@garrettmknight I’ve reported this issue and have more context on it, so I can support with reviewing the proposal as a C+

melvin-bot[bot] commented 2 days ago

Job added to Upwork: https://www.upwork.com/jobs/~021861840903242082245

melvin-bot[bot] commented 2 days ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

thesahindia commented 2 days ago

@nkdengineer's proposal looks good to me!

🎀 👀 🎀 C+ reviewed

melvin-bot[bot] commented 2 days ago

Triggered auto assignment to @madmax330, see https://stackoverflow.com/c/expensify/questions/7972 for more details.