[HOLD for payment 2024-12-05] Submit expense - Next Steps shows "Waiting for You to pay" when payment is blocked by violations

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.67-0 Reproducible in staging?: Y Reproducible in production?: N Email or phone of affected tester (no customers): applausetester+bm1jd9@applause.expensifail.com Issue reported by: Applause Internal Team

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Create workspace
3. Go to categories > settings > enable "Members must categorize all expenses"
4. Go to the workspace chat and submit an expense
5. Click on the expense preview then see the next steps.

Expected Result:

The next steps should ask the user to fix the violation instead of stating "Waiting for You to pay."

Actual Result:

The next steps message displays "Waiting for You to pay expense(s)" even when payment is blocked due to a violation.

Workaround:

Unknown

Platforms:

• [ ] Android: Standalone
• [ ] Android: HybridApp
• [x] Android: mWeb Chrome
• [ ] iOS: Standalone
• [ ] iOS: HybridApp
• [ ] iOS: mWeb Safari
• [x] MacOS: Chrome / Safari
• [ ] MacOS: Desktop

Screenshots/Videos

https://github.com/user-attachments/assets/82ca3728-f397-481b-b02c-33a24c3649eb

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @OfstadC

[melvin-bot[bot]]

Triggered auto assignment to @OfstadC (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot[bot]]

Triggered auto assignment to @flodnv (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot[bot]]

💬 A slack conversation has been started in #expensify-open-source

[github-actions[bot]]

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[mountiny]

https://github.com/user-attachments/assets/d812bcb6-e3c7-4e99-8911-06109231ad8d

@IuliiaHerets @kavimuru, I could repro this in production. Did the tester test this change in production before labelling it as a blocker?

Gonna remove the label, but we should look into it.

I assume the problem is that its the admin/policy owner and the submitter all in one so probably the logic is incorrectly picking priority.

[IuliiaHerets]

@mountiny In prod, the Pay button is available but on stg payment is blocked when there is a violation.

[IuliiaHerets]

@mountiny Tester shared the video

https://github.com/user-attachments/assets/1af1ccab-6fc3-4352-95d7-357d0d73141e

[flodnv]

Adding the label back: https://expensify.slack.com/archives/C01GTK53T8Q/p1732737120984209?thread_ts=1732649367.590529&cid=C01GTK53T8Q

[github-actions[bot]]

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[mountiny]

Revert being CPed

[flodnv]

Cool, can we close this?

[mountiny]

Original PR was reverted so we will handle it back in this issue https://github.com/Expensify/App/issues/50479 cc @abzokhattab @hoangzinh you might have to wait for after thanksgiving for the internal people to come back to see what are the next steps on that issue

[melvin-bot[bot]]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot[bot]]

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.67-9 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/53230

If no regressions arise, payment will be issued on 2024-12-05. :confetti_ball:

[melvin-bot[bot]]

@flodnv / @mountiny @OfstadC @flodnv / @mountiny The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]