Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.66k stars 2.93k forks source link

[HOLD for payment 2024-12-11] Android - Start chat - Huge spacing between bottom button and offline indicator #53189

Open IuliiaHerets opened 1 week ago

IuliiaHerets commented 1 week ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.67-1 Reproducible in staging?: Y Reproducible in production?: N If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y Email or phone of affected tester (no customers): applausetester+232803@applause.expensifail.com Issue reported by: Applause Internal Team

Action Performed:

Precondition:

  1. Launch ND or hybrid.
  2. Go offline.
  3. Open FAB > Start chat.
  4. Tap Add to group next to any user.
  5. Note that there is huge spacing between Next button and offline indicator.
  6. Go to #room.
  7. Note that there is huge spacing between Create room button and offline indicator.

Expected Result:

There should not be huge spacing between bottom button and offline indicator.

Actual Result:

There is huge spacing between bottom button and offline indicator.

This issue is not reproducible if device navigation uses swipe gestures.

Workaround:

Unknown

Platforms:

Screenshots/Videos

https://github.com/user-attachments/assets/f1d76c8a-a479-4c67-a6b6-875caf87a5eb

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @sakluger
melvin-bot[bot] commented 1 week ago

Triggered auto assignment to @cristipaval (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

melvin-bot[bot] commented 1 week ago

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] commented 1 week ago

💬 A slack conversation has been started in #expensify-open-source

github-actions[bot] commented 1 week ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
mountiny commented 1 week ago

Its from the edge-to-edge PR cc @kirillzyusko @chrispader

mountiny commented 1 week ago

discussing in the linked thread

kirillzyusko commented 1 week ago

@chrispader is going to take this over (according to Slack conversation)

mountiny commented 1 week ago

This is purely a UI issue on Android native, not blocking the user from using the App. We are working on more holistic changes for the safe area and padding in android native

mountiny commented 2 days ago

PR is in main

sakluger commented 2 days ago

@mountiny do you mind linking the PR?

Also, @chrispader, if you would like me to assign you on this GH issue, you'll need to leave a comment. If you don't need to be assigned, then no worries.

mountiny commented 2 days ago

ah it was not linked correctly in the PR, here it is https://github.com/Expensify/App/pull/53250

kirillzyusko commented 2 days ago

@mountiny has it been fixed by changes from #53250?

mountiny commented 1 day ago

Asked QA here

izarutskaya commented 1 day ago

The space between offline indicator and the button is still visible. Also, the offline indicator overlaps the navigation tab of the device. Build 9.0.70-1

https://github.com/user-attachments/assets/b9b1a028-596b-41ae-b0b5-3b0847ed3941

melvin-bot[bot] commented 21 hours ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 21 hours ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.70-9 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-12-11. :confetti_ball:

For reference, here are some details about the assignees on this issue:

melvin-bot[bot] commented 21 hours ago

@mountiny @sakluger @kirillzyusko The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]