Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.65k stars 2.93k forks source link

[HOLD for payment 2024-12-11] [HOLD App#53192] Expensify Card - Navigation bar overlaps the Next button in Choose a limit type step #53217

Open lanitochka17 opened 1 week ago

lanitochka17 commented 1 week ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.67-1 Reproducible in staging?: Y Reproducible in production?: N If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5268041 Issue reported by: Applause - Internal Team

Action Performed:

Preconditions User logged in with an expensifail account. User is an admin of a workspace and has enabled Expensify Cards in more features. Workflows MUST be disabled in the workspace. User has set a fully verified VBA before. Steps

  1. Add another member to the WS so there's at least 2 members
  2. Navigate to the "Expensify Card" page in WS settings
  3. Tap on "Issue new card"
  4. Select the user you are using
  5. Select Virtual Card

Expected Result:

The Next button in the "Select a Limit Type" step should be displayed above the navigation bar

Actual Result:

The navigation bar overlaps the Next button in the "Choose a limit type" step

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/cf12de19-f001-4f5f-a7b1-8e522c4b7a58

Bug6677640_1732677257890!Next_button (1)

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @muttmuure
melvin-bot[bot] commented 1 week ago

Triggered auto assignment to @stitesExpensify (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

melvin-bot[bot] commented 1 week ago

💬 A slack conversation has been started in #expensify-open-source

github-actions[bot] commented 1 week ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
mountiny commented 1 week ago

Similar to other android issues with the margin now after enabling the edge-to-edge feature cc @chrispader @kirillzyusko

kirillzyusko commented 1 week ago

Yes, looks like safe area padding is missing on Android

melvin-bot[bot] commented 1 week ago

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

mountiny commented 1 week ago

@kirillzyusko i will put this on hold for the other issue

melvin-bot[bot] commented 3 days ago

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

melvin-bot[bot] commented 19 hours ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 19 hours ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.70-9 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-12-11. :confetti_ball:

For reference, here are some details about the assignees on this issue:

melvin-bot[bot] commented 19 hours ago

@c3024 @muttmuure @c3024 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]