[HOLD App#53229] Accounting - Next button doesn't have bottom margin on intacct setup first page

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.67-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers): nathanmulugetatesting+2193@gmail.com Issue reported by: Applause - Internal Team

Action Performed:

1. Create a workspace and enable accounting
2. Navigate to accounting and Tap on connect on Sage Intacct
3. Observe the Next button and tap on next

Expected Result:

There is a bottom margin for next button

Actual Result:

There is no bottom margin for next button on the first setup page of Intacct

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [x] Android: Standalone
• [x] Android: HybridApp
• [ ] Android: mWeb Chrome
• [ ] iOS: Standalone
• [ ] iOS: HybridApp
• [ ] iOS: mWeb Safari
• [ ] MacOS: Chrome / Safari
• [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/cafbfb3f-6a0d-4d04-a71f-285f1bd55489

View all open jobs on GitHub

[melvin-bot[bot]]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[Krishna2323]

Edited by proposal-police: This proposal was edited at 2024-11-27 16:46:11 UTC.

Proposal


Please re-state the problem that we are trying to solve in this issue.

Accounting - Next button doesn't have bottom margin on intacct setup first page

What is the root cause of that problem?

• Safe area padding bottom is not applied. https://github.com/Expensify/App/blob/9ea0f51cba69f6183386eeb39f5f751e77968271/src/pages/workspace/accounting/intacct/SageIntacctPrerequisitesPage.tsx#L88-L96

What changes do you think we should make in order to solve the problem?


• We should use const safePaddingBottomStyle = useSafePaddingBottomStyle(); and pass includeSafeAreaPaddingBottom={false} to ScreenWrapper.
• Or we can use useSafePaddingBottomStyle inside FixedFooter and remove useSafeAreaInsets.

What alternative solutions did you explore? (Optional)

Result

[melvin-bot[bot]]

Triggered auto assignment to @aldo-expensify (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot[bot]]

💬 A slack conversation has been started in #expensify-open-source

[github-actions[bot]]

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

Production:

https://github.com/user-attachments/assets/837e4416-333c-41ce-ba41-c281da3e404a

[mountiny]

cc @chrispader @kirillzyusko Another bottom margin one

[aldo-expensify]

@mountiny 👋 , are you going to handle this? (asking because of the self-assign :) )

[mountiny]

Based on the video this is very minor and we wont block deploy on this one.

@kirillzyusko lets still assign you to fix these

[melvin-bot[bot]]

Current assignee @JmillsExpensify is eligible for the Bug assigner, not assigning anyone new.

[mountiny]

Putting this on hold for holistic safearea management