Closed marcaaron closed 3 years ago
Looking into this and currently able to reliably reproduce locally. Back with more info soon.
Ok, here's what I found...
ResendValidateCode
which triggers the email notification to be queued in Auth and we add a validateCode here GetAccountValidateCode
(whatever that is) runs and overwrites the existing code. This happens when the notification is sent in Standard.php
hereStandard.php
I have a feeling the change here broke this cc @jasperhuangg
Won't be able to get to this today but that investigation should be enough for someone to go off of.
I investigated this for a while and I agree with @marcaaron the breaking change is https://github.com/Expensify/Auth/pull/5903/files#diff-7b6cd1030cc3fe6a8bbc09ce2c558b5e91f8df9099f648aae3f59c7f9900f5e8R84
This is happening in the SetCashPassword (NewDot) flow but not in the CreateAccount2 (OldDot) flow because the NewDot flow sets an authToken and we get into here as @marcaaron pointed out.
I am working on a PR but I think more things are broken than what we expected, eg this: https://github.com/Expensify/App/pull/5218/files#r712306088
Triggered auto assignment to @SofiedeVreese (External
), see https://stackoverflow.com/c/expensify/questions/8582 for more details.
Sorry @SofiedeVreese I fat fingered that...
This issue is fixed now.
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
main
branch and also tested against production)Most recently tested on
john+4@lorenabobbeth.de
Expected Result:
Validating the account and setting a password is possible
Actual Result:
Seemingly impossible
Workaround:
Request the validate email via Old Dot, get the magic sign in link, sign in and set a password there.
Platform:
Where is this issue occurring?
Version Number: Reproducible in staging?: YES Reproducible in production?: YES Logs: https://www.expensify.com/_devportal/tools/logSearch/#sort=asc&size=20000&query=email%3A%22john%2B4%40lorenabobbeth.de%22%20AND%20timestamp%3A%5B2021-09-17T00%3A00%20TO%202021-09-18T23%3A59%5D Notes/Photos/Videos: Any additional supporting documentation Expensify/Expensify Issue URL: Issue reported by: Slack conversation:
View all open jobs on GitHub