Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.68k stars 2.93k forks source link

Login - Onboarding modal does not appear when logging in with a new account #53284

Open IuliiaHerets opened 6 days ago

IuliiaHerets commented 6 days ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.0.68-0 Reproducible in staging?: Y Reproducible in production?: Y Email or phone of affected tester (no customers): htad26+dfgssdsddhgf@gmail.com Issue reported by: Applause Internal Team

Action Performed:

  1. Navigate to staging.new.expensify.com
  2. Log in with a new gmail account

Expected Result:

Onboarding modal appears when logging in with a new Gmail account

Actual Result:

Onboarding modal doesn't appear when logging in with a new Gmail account. User is logged in to the account directly without the onboarding proccess

Workaround:

Unknown

Platforms:

Screenshots/Videos

https://github.com/user-attachments/assets/d102ebc8-68f3-4af3-aa1d-2bdb5c444e59

View all open jobs on GitHub

melvin-bot[bot] commented 6 days ago

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

NJ-2020 commented 4 days ago

BE issue, OpenApp api command returning empty object for onboarding value Screenshot 2024-11-30 at 15 45 09

melvin-bot[bot] commented 2 days ago

@muttmuure Whoops! This issue is 2 days overdue. Let's get this updated quick!

mountiny commented 2 days ago

Cc @trjExpensify

trjExpensify commented 2 days ago

Ah, is this the bug you saw on dev only? 🤔

trjExpensify commented 2 days ago

Discussing in this thread.

trjExpensify commented 1 day ago

Taking this over. Vit has a PR up.

mountiny commented 1 day ago

PR is merged, but we could not reproduce locally as this seems to be some production specific issue when user runs into a commit, this explains flakiness. hopefully this change will fix it