Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.68k stars 2.93k forks source link

[HOLD App#49539] [$250] iOS - Inbox becomes blank briefly after several navigation from workspace settings #53348

Open IuliiaHerets opened 4 days ago

IuliiaHerets commented 4 days ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.69-1 Reproducible in staging?: Y Reproducible in production?: N If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N Email or phone of affected tester (no customers): applausetester+232803@applause.expensifail.com Issue reported by: Applause Internal Team

Action Performed:

  1. Launch ND or hybrid app.
  2. Go to workspace settings.
  3. Tap on the workspace chat in workspace editor.
  4. Swipe to the right three times (iOS swiping style) to return to Inbox.

Expected Result:

Inbox will not turn blank briefly when navigating back to Inbox.

Actual Result:

Inbox turns blank briefly when navigating back to Inbox.

Workaround:

Unknown

Platforms:

Screenshots/Videos

https://github.com/user-attachments/assets/3617df5a-a71d-4b6b-a9e4-b4ffb73b4a6c

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021863134374595140416
  • Upwork Job ID: 1863134374595140416
  • Last Price Increase: 2024-12-01
  • Automatic offers:
    • c3024 | Reviewer | 105155696
Issue OwnerCurrent Issue Owner: @c3024
melvin-bot[bot] commented 4 days ago

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] commented 4 days ago

Triggered auto assignment to @tylerkaraszewski (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

melvin-bot[bot] commented 4 days ago

💬 A slack conversation has been started in #expensify-open-source

github-actions[bot] commented 4 days ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
mountiny commented 3 days ago

@chrispader @kirillzyusko @hannojg something to look into, i dont think this is a blocker so demoted.

melvin-bot[bot] commented 3 days ago

Job added to Upwork: https://www.upwork.com/jobs/~021863134374595140416

melvin-bot[bot] commented 3 days ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (External)

WojtekBoman commented 2 days ago

Hi! I'll take a look at it :)

melvin-bot[bot] commented 2 days ago

📣 @c3024 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job

mountiny commented 1 day ago

Any luck so far @WojtekBoman ?

WojtekBoman commented 1 day ago

I'm still investigating it 👀

WojtekBoman commented 11 hours ago

@mountiny

I don't know how urgent this task is, but I checked how it works on our branch with improved bottom tabs and it seems that this issue doesn't occur there, because workspace settings page contains the bottom tab bar and it's not possible to go back using swipe on this page. If we can wait for our PR to be merged, I believe we can put this issue on hold. If not I'll try to find a solution for the current version :) I'm attaching videos with a reproduction of this issue from our PR:

https://github.com/user-attachments/assets/6c215b08-12d0-4bf9-9838-aaa3b18a0fd7

https://github.com/user-attachments/assets/d32f53d9-a304-4493-b5f1-59cc88f5deed

mountiny commented 8 hours ago

it's not possible to go back using swipe on this page.

I think we might need to discuss that on the PR