Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
This issue is just to keep track of this proposal and eventually create a P/S in Slack
Problem
As discussed in this issue and this Slack thread we should replace modal screens (navigation screens/routes, that only render a modal) and modals that stay open when the containing screen gets unmounted.
The current modals use react-native-modal which uses RN internal Modal under the hood. Using these modals with @react-navigation/native-stack poses issues with animations and navigation, as these modals cannot animate in/out, due to the screen mounting/unmounting at the same time. Additionally, the animations will not look the same as the rest of the screen animations, which doesn't look very nice.
Solution
Replace the following types of modals with modal (screens) from @react-navigation
screens/routes that only render a modal
modals on screens, that are navigated back from while the modal is still open or animating out at the same time
This issue is just to keep track of this proposal and eventually create a P/S in Slack
Problem
As discussed in this issue and this Slack thread we should replace modal screens (navigation screens/routes, that only render a modal) and modals that stay open when the containing screen gets unmounted.
The current modals use
react-native-modal
which uses RN internal Modal under the hood. Using these modals with@react-navigation/native-stack
poses issues with animations and navigation, as these modals cannot animate in/out, due to the screen mounting/unmounting at the same time. Additionally, the animations will not look the same as the rest of the screen animations, which doesn't look very nice.Solution
Replace the following types of modals with modal (screens) from
@react-navigation
cc @mountiny