Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.63k stars 2.93k forks source link

Editing card feed name doesn't work on mobile #53515

Open m-natarajan opened 12 hours ago

m-natarajan commented 12 hours ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: Reproducible in staging?: Reproducible in production?: If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Slack conversation (hyperlinked to channel name): ts_external_expensify_expense

Action Performed:

Prerequisite: User added a company card

  1. Click settings for the added card
  2. Click on the Card feed name
  3. Enter any name and save
  4. Click the back arrow two times to view the company cards page

Expected Result:

Entered name updated in the card feed name

Actual Result:

Updated name not saved and default card name displayed

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/e96c0ae9-beaf-4595-97de-1277d00147fa

View all open jobs on GitHub

melvin-bot[bot] commented 12 hours ago

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

VickyStash commented 7 hours ago

Hi, I'm Viktoryia from Callstack - expert contributor group - and I would like to work on this issue.

VickyStash commented 6 hours ago

I've tried with several feeds and wasn't able to reproduce the bug. Asked for more details in the slack.

DylanDylann commented 6 hours ago

Contributor Plus of Company Feed Feature - I'd love to take this issue with VickyStash

VickyStash commented 19 minutes ago

Updates: It looks like it's a back-end issue. After feed name update the OpenPolicyCompanyCardsPage API call returns companyCardNicknames in the format:

 "companyCardNicknames": {
         "oauth": {
              "wellsfargo": {
                   "com": "test"
               }
          }
},

while app expects it to be

"companyCardNicknames": {
    "oauth.wellsfargo.com": "test"
}

The discussion is in the slack.