[$250] Report fields - Initial value field name is "Date" for text report field

vincdargento commented 8 hours ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.71-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers): applausetester+khcategory18@applause.expensifail.com Issue reported by: Applause Internal Team

Action Performed:

Go to staging.new.expensify.com
Go to workspace settings > Report fields.
Click Add field.
Click Type and select Text.
Note that the initial value field name is "Initial value".
Enter a report field name and save it.
Click on the added text report field.

Expected Result:

The initial value field name is "Initial value".

Actual Result:

The initial value field name is "Date".

Workaround:

Unknown

Platforms:

[x] Android: Standalone
[x] Android: HybridApp
[x] Android: mWeb Chrome
[x] iOS: Standalone
[x] iOS: HybridApp
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos

https://github.com/user-attachments/assets/e6de8f3b-0e71-413e-8711-70266f5e9daf

bug

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021864332553645385180
Upwork Job ID: 1864332553645385180
Last Price Increase: 2024-12-04
Automatic offers:

Krishna2323 | Contributor | 105197849

Issue Owner

Current Issue Owner: @fedirjh

melvin-bot[bot] commented 8 hours ago

Triggered auto assignment to @carlosmiceli (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

melvin-bot[bot] commented 8 hours ago

💬 A slack conversation has been started in #expensify-open-source

melvin-bot[bot] commented 8 hours ago

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

github-actions[bot] commented 8 hours ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

vincdargento commented 8 hours ago

@abekkala FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

melvin-bot[bot] commented 8 hours ago

Job added to Upwork: https://www.upwork.com/jobs/~021864332553645385180

melvin-bot[bot] commented 8 hours ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

nkdengineer commented 7 hours ago

Edited by proposal-police: This proposal was edited at 2024-12-04 15:50:15 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

The initial value field name is "Date".

What is the root cause of that problem?

We are wrong when set description as date here

https://github.com/Expensify/App/blob/f386a072eb09d669ce8a0802acf68386352cf957/src/pages/workspace/reportFields/ReportFieldsSettingsPage.tsx#L116

What changes do you think we should make in order to solve the problem?

We should convert this to description={translate('common.initialValue')} if not is date type

      description={isDateFieldType ? translate('common.date') : translate('common.initialValue')}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

linhvovan29546 commented 7 hours ago

Edited by proposal-police: This proposal was edited at 2024-12-04 16:16:50 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Report fields - Initial value field name is "Date" for text report field

What is the root cause of that problem?

In the ReportFieldsSettingsPage file, there are three field types on the page (list, date, text). https://github.com/Expensify/App/blob/1d36289a5c3ae312244d2b9dc2ef1e4a5c72b0f6/src/pages/workspace/reportFields/ReportFieldsSettingsPage.tsx#L111-L119 The current implementation uses a simple boolean check to differentiate these types, leading to incorrect value field name.
What changes do you think we should make in order to solve the problem?

Refactor the field-rendering logic to use a switch-case structure. This approach will:

Dynamically determine the UI field value for each reportField type.
Improve scalability.
Example


const renderFieldName = () => {
switch (reportField.type) {
    case CONST.REPORT_FIELD_TYPES.DATE:
    case CONST.REPORT_FIELD_TYPES.TEXT:
        // return component here

        return;
    case CONST.REPORT_FIELD_TYPES.LIST:
        // return component here
        return;
    default:
        // return component here
        return;
}
}`
### What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A

What alternative solutions did you explore? (Optional)

As mentioned in the other proposal above, we check the type of reportField to display description

twilight2294 commented 3 hours ago

regression from https://github.com/Expensify/App/pull/50827

Krishna2323 commented 1 hour ago

@carlosmiceli, I can handle this if needed, as it's a regression from my PR.

melvin-bot[bot] commented 1 hour ago

📣 @Krishna2323 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

carlosmiceli commented 1 hour ago

@carlosmiceli, I can handle this if needed, as it's a regression from my PR.

Sounds good! Thank you!

Krishna2323 commented 30 minutes ago

@rushatgabhane could you please review the PR above ^? This is a regression from https://github.com/Expensify/App/pull/53611

Expensify / App