search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.68k stars 2.93k forks source link

QBD - QBD is displayed like an established connection without error after dismissing the RHP #53608

Open vincdargento opened 6 hours ago

vincdargento commented 6 hours ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.71-1 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5297104 Email or phone of affected tester (no customers): N/A Issue reported by: Applause Internal Team

Action Performed:

  1. Go to ND and log in with a new expensifail account
  2. Create a new collect workspace
  3. Go to "More Features" in workspace settings
  4. Enable the Accounting toggle
  5. Navigate to Accounting
  6. Click on the connect button next to QBD
  7. Upgrade your workspace to Control plan
  8. Dismiss the RHP before the setup link appears
  9. Navigate to any other page in workspace settings
  10. Go back to Accounting

Expected Result:

QuickBooks Desktop should not be displayed as if a successful connection was made due to the RHP being dismissed even before the setup link appears. The behavior should be similar to the other integrations.

Actual Result:

QBD is displayed like an established connection without error after dismissing the RHP before the setup link appears.

Workaround:

Unknown

Platforms:

Screenshots/Videos

https://github.com/user-attachments/assets/1e07d67c-0a1b-467f-901f-f1582d49770b

View all open jobs on GitHub

melvin-bot[bot] commented 6 hours ago

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.