VBA: always show all address fields

aldo-expensify commented 2 years ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Details

Following this slack convo: https://expensify.slack.com/archives/C03TQ48KC/p1635812089454700 Related GH issues:

We will be doing the following changes related to the address fields in the VBA flow:

Always show all separate inputs for: city, state, street + number + (apt number), zip code
The input street + number will keep its autocomplete behaviour.
If the user selects a result, we will populate other fields. If the result is missing any part of the address (i.e. city), we will just ignore that part.
The user will be allowed to manipulate and enter data manually in any of the address components (i.e. add the apt number to the street + number input)

The following steps have to be consistently updated:

Company information
Personal information (requestor)
Additional information (beneficial owners)

Expected Result:

Actual Result:

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platform:

Where is this issue occurring?

Web
iOS
Android
Desktop App
Mobile Web

Version Number: Reproducible in staging?: Reproducible in production?: Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation Expensify/Expensify Issue URL: Issue reported by: Slack conversation:

View all open jobs on GitHub

aldo-expensify commented 2 years ago

Resolving conflicts, after that it should be ready for review.

MelvinBot commented 2 years ago

@aldo-expensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

MelvinBot commented 2 years ago

@aldo-expensify Eep! 4 days overdue now. Issues have feelings too...

aldo-expensify commented 2 years ago

I haven't been able to continue with this yet, I'll try to give it time tomorrow.

aldo-expensify commented 2 years ago

We may have to redo this PR and split it in two, but have been working on other higher priority things.

I'll change this to weekly because with the current UI, the user can enter any address manually. This used to be more pressing when that option was not available.

aldo-expensify commented 2 years ago

I'll be going on vacations for the next 2 weeks, so I'll un-assign myself from this to make it visible to other developers.

Feel free to work on it, continue the PR or do a new PR!

If the issue is still around when I get back, I'll get back to it!

Expensify / App