Closed isagoico closed 2 years ago
Triggered auto assignment to @tgolen (Engineering
), see https://stackoverflow.com/c/expensify/questions/4319 for more details.
Triggered auto assignment to @Christinadobrzyn (External
), see https://stackoverflow.com/c/expensify/questions/8582 for more details.
Hum, I don't see the same thing on my NewDot app - here are the steps I took
Running v1.1.17-4
@Santhosh-Sellavel can try again with an update version - v1.1.17-4 - to see if you see the same thing?
Yep working fine, I was able to reproduce in version 1.1.17.2 or earlier!
But it was handled in latest build?
Ah great! It seems like there have been several updates over the past 24 hours so I assume something in those updates resolved this. However, I remember always seeing the admin in the previous version so maybe something was in the middle of an update when you caught this.
We're good to close this?
Its good that its resolved now, we can close this one!
Reopening this - This is still happening on Android app on version 1.1.17-4
Yep, it is still reproducible. My bad I didn’t verify in android earlier!
Ah, thanks for clarifying @isagoico and @Santhosh-Sellavel!
Created Upwork job Internal - https://www.upwork.com/ab/applicants/1466605040031260672/job-details External - https://www.upwork.com/jobs/~01c043b2222fa54500
Hired @Santhosh-Sellavel for reporting - waiting on proposals for the fix!
Triggered auto assignment to @parasharrajat (Exported
)
Current assignee @tgolen is eligible for the Exported assigner, not assigning anyone new.
Issue occurs again in iOS again in version 1.1.17.5 @puneetlath reported in slack thread
It seems that getFullPolicy
https://github.com/Expensify/App/blob/d279c8abf165af6b04032593e99901fe6328b90f/src/pages/workspace/withFullPolicy.js#L93 call is failing for some reason. I am not able to inspect the request in the network. Or don't know how to do that in Flipper.
:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash
deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Adding the deploy blocker here - this issue is failing PR https://github.com/Expensify/App/pull/6542 in the current regression checklist for iOS and Android.
I'm a little confused. That PR is linked to a different issue: https://github.com/Expensify/App/issues/6287. Was this issue marked as a blocker by mistake?
@tgolen Nope. Marked this issue as deploy blocker because it's completely blocking us from verifying QA on iOS and Android for this PR https://github.com/Expensify/App/issues/6287.
We usually mark issues that are blocking and/or failing the QA of PRs as deploy blockers.
Oh! I understand now. Got it. Looks like we're still looking for proposals to fix this.
It looks like the employeeList that is being sent back is different on iOS/Android compared to web. On web, the employeeList contains all the employees but on mobile it does not, it just contains the user email. I looked into the logs for this and it seems like the Get
request we make for policyIDList
in this call is coming up as an empty string on the API side when called from mobile, but when it is called from web it is the correct value.
I'm not sure what is causing this yet, but there's a chance it requires a back end fix so leaving some internal logs here:
also verified that the data
here is an empty array on Android:
But not on web.
Can see the employeeList getting returned in Flipper when making the request on Android:
Removed the posting from Upwork since this is being handled internally
This qualifies for reporting bonus right? @Jag96 or @Christinadobrzyn
@Santhosh-Sellavel correct! I've created an upwork posting for that here and hired you for the job!
Thanks! @Jag96
I'll keep an eye on this PR and pay @Santhosh-Sellavel at our 7 day after production payment timeframe.
I just noticed, there are two active contracts for the same job. cc: @Christinadobrzyn Can you end one contract?
Thanks for letting me know @Santhosh-Sellavel! I think I cancelled one of the contracts but Upworks isn't loading to show which one was cancelled. You might get a message in Upwork about it.
Either way, I will track both of these and make sure to pay you for one of them after the production deployment.
Hey @Santhosh-Sellavel sorry for the delay with this - I just paid you for reporting this in this job. Thanks!
https://www.upwork.com/ab/applicants/1466605040031260672/job-details
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
Manage members screen is fully rendered
Actual Result:
Manage members screen is blank on mobile devices.
Workaround:
None found in Android / iOS.
Platform:
Where is this issue occurring?
Version Number: 1.1.17-0
Reproducible in staging?: Yes Reproducible in production?: Yes
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @Santhosh-Sellavel Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1638132040029300
View all open jobs on GitHub