Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.51k stars 2.87k forks source link

Android & iOS - Manage members screen is blank #6528

Closed isagoico closed 2 years ago

isagoico commented 2 years ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open the app in a Android or iOS device
  2. Navigate to Edit Workspace settings
  3. Click on manage members

Expected Result:

Manage members screen is fully rendered

Actual Result:

Manage members screen is blank on mobile devices.

Workaround:

None found in Android / iOS.

Platform:

Where is this issue occurring?

Version Number: 1.1.17-0

Reproducible in staging?: Yes Reproducible in production?: Yes

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:

Issue reported by: @Santhosh-Sellavel Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1638132040029300

View all open jobs on GitHub

MelvinBot commented 2 years ago

Triggered auto assignment to @tgolen (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

MelvinBot commented 2 years ago

Triggered auto assignment to @Christinadobrzyn (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

Christinadobrzyn commented 2 years ago

Hum, I don't see the same thing on my NewDot app - here are the steps I took

  1. Open the app on iOS device
  2. Tap my my profile > tap C.dobrzyn's workspace
  3. Tap on manage members and I see my admin displayed:

Running v1.1.17-4

@Santhosh-Sellavel can try again with an update version - v1.1.17-4 - to see if you see the same thing?

Santhosh-Sellavel commented 2 years ago

Yep working fine, I was able to reproduce in version 1.1.17.2 or earlier!

But it was handled in latest build?

Christinadobrzyn commented 2 years ago

Ah great! It seems like there have been several updates over the past 24 hours so I assume something in those updates resolved this. However, I remember always seeing the admin in the previous version so maybe something was in the middle of an update when you caught this.

We're good to close this?

Santhosh-Sellavel commented 2 years ago

Its good that its resolved now, we can close this one!

isagoico commented 2 years ago

Reopening this - This is still happening on Android app on version 1.1.17-4

Santhosh-Sellavel commented 2 years ago

Yep, it is still reproducible. My bad I didn’t verify in android earlier!

Christinadobrzyn commented 2 years ago

Ah, thanks for clarifying @isagoico and @Santhosh-Sellavel!

Created Upwork job Internal - https://www.upwork.com/ab/applicants/1466605040031260672/job-details External - https://www.upwork.com/jobs/~01c043b2222fa54500

Hired @Santhosh-Sellavel for reporting - waiting on proposals for the fix!

MelvinBot commented 2 years ago

Triggered auto assignment to @parasharrajat (Exported)

MelvinBot commented 2 years ago

Current assignee @tgolen is eligible for the Exported assigner, not assigning anyone new.

Santhosh-Sellavel commented 2 years ago

Issue occurs again in iOS again in version 1.1.17.5 @puneetlath reported in slack thread

parasharrajat commented 2 years ago

It seems that getFullPolicy https://github.com/Expensify/App/blob/d279c8abf165af6b04032593e99901fe6328b90f/src/pages/workspace/withFullPolicy.js#L93 call is failing for some reason. I am not able to inspect the request in the network. Or don't know how to do that in Flipper.

OSBotify commented 2 years ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
isagoico commented 2 years ago

Adding the deploy blocker here - this issue is failing PR https://github.com/Expensify/App/pull/6542 in the current regression checklist for iOS and Android.

tgolen commented 2 years ago

I'm a little confused. That PR is linked to a different issue: https://github.com/Expensify/App/issues/6287. Was this issue marked as a blocker by mistake?

isagoico commented 2 years ago

@tgolen Nope. Marked this issue as deploy blocker because it's completely blocking us from verifying QA on iOS and Android for this PR https://github.com/Expensify/App/issues/6287.

We usually mark issues that are blocking and/or failing the QA of PRs as deploy blockers.

tgolen commented 2 years ago

Oh! I understand now. Got it. Looks like we're still looking for proposals to fix this.

Jag96 commented 2 years ago

It looks like the employeeList that is being sent back is different on iOS/Android compared to web. On web, the employeeList contains all the employees but on mobile it does not, it just contains the user email. I looked into the logs for this and it seems like the Get request we make for policyIDList in this call is coming up as an empty string on the API side when called from mobile, but when it is called from web it is the correct value.

I'm not sure what is causing this yet, but there's a chance it requires a back end fix so leaving some internal logs here:

marcaaron commented 2 years ago

also verified that the data here is an empty array on Android:

https://github.com/Expensify/App/blob/04d28afec2f090aa23fbca496671ba3d2214003f/src/pages/workspace/WorkspaceMembersPage.js#L248

But not on web.

marcaaron commented 2 years ago

Can see the employeeList getting returned in Flipper when making the request on Android:

2021-12-07_12-31-10

Jag96 commented 2 years ago

Removed the posting from Upwork since this is being handled internally

Santhosh-Sellavel commented 2 years ago

This qualifies for reporting bonus right? @Jag96 or @Christinadobrzyn

Jag96 commented 2 years ago

@Santhosh-Sellavel correct! I've created an upwork posting for that here and hired you for the job!

Santhosh-Sellavel commented 2 years ago

Thanks! @Jag96

Christinadobrzyn commented 2 years ago

I'll keep an eye on this PR and pay @Santhosh-Sellavel at our 7 day after production payment timeframe.

Santhosh-Sellavel commented 2 years ago

I just noticed, there are two active contracts for the same job. cc: @Christinadobrzyn Can you end one contract?

Screenshot 2021-12-09 at 7 44 11 AM
Christinadobrzyn commented 2 years ago

Thanks for letting me know @Santhosh-Sellavel! I think I cancelled one of the contracts but Upworks isn't loading to show which one was cancelled. You might get a message in Upwork about it.

Either way, I will track both of these and make sure to pay you for one of them after the production deployment.

Christinadobrzyn commented 2 years ago

Hey @Santhosh-Sellavel sorry for the delay with this - I just paid you for reporting this in this job. Thanks!

https://www.upwork.com/ab/applicants/1466605040031260672/job-details