[HOLD for payment 2022-05-23] [$250] Auto-handle phone number format by stripping any parentheses/dashes on submit - Reported by @thesahindia

[mvtglobally]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open app
2. Navigate to Settings > Workspace > Connect bank account
3. Proceed with VBA flow to Company information page
4. Enter phone number in different formats (e.g with/without parentheses/dashes)

Expected Result:

User should be able to enter phone number in any format

Actual Result:

The phone number placeholder suggests that the input should be in this format (xxx)xxx-xxxx however, it will throw an error if we do that. So, either the placeholder should be updated or the input should be handled accordingly.

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.1.24-0 Reproducible in staging?: Y Reproducible in production?: Y Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation

https://user-images.githubusercontent.com/43995119/148008018-4a6b6ec5-cdbb-4d2a-92d8-0287b82abc99.mov

Expensify/Expensify Issue URL: Issue reported by: @thesahindia Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1640355502103900

View all open jobs on GitHub

[marcaaron]

Sorry, I don't understand the question or what exactly you need help with. Can you ask it another way or provide more detail? Maybe asking publicly in the Slack channel will help us get unblocked.

[marcaaron]

Linking to examples in the code when asking your question will probably help me get what you need confirmation on...

[thesahindia]

For invalid phone number we were showing this error: Please enter a valid phone number without brackets or dashes. If you're outside the US please include your country code, eg. +447782339811

But now the user can enter brackets and dashes in the phone number so we have removed this line: Please enter a valid phone number without brackets or dashes.

And at Add phone number page we show a different error: I couldn't validate the phone number, please try again with the country code (e.g. +15005550006) which is from backend. So, I am asking do we wanna use the same error message that we are using at some other places for consistency or can we leave this one as the error message is correct and doesn't need any change.

@marcaaron, just need a small confirmation about the error message here.

[marcaaron]

I don't know the answer sorry, this would be best to ask marketing or in the open source channel.

[kadiealexander]

Posted in #expensify-open-source here to get consensus.

[kadiealexander]

@thesahindia, please proceed with the same error message as other places in the product:

I couldn't validate the phone number, please try again with the country code (e.g. +15005550006)

Thanks!!

[kadiealexander]

@parasharrajat would you mind reviewing @thesahindia's PR here? https://github.com/Expensify/App/pull/7328

[parasharrajat]

On my list. Coming back to it. There was a long delay for requested changes which shifted the priority for this PR.

[thesahindia]

@kadiealexander, I have asked some questions on slack but didn't get much 👀. Can you help? Here's the thread.

[kadiealexander]

@thesahindia I see that @luacmartins has responded since you asked this, are you still needing further help?

[thesahindia]

Nope, it's good now, got the answer.

[marcaaron]

What's the latest here?

[thesahindia]

@luacmartins suggested that instead of using a new component we should be stripping parentheses and dashes at validation and on form submission.

I'm not sure that I agree 100% with creating yet another component for this. I'd think that we should strip special chars for frontend validation and on form submission.

So we are thinking to do the same. Can you share you thoughts?

[thesahindia]

bump @marcaaron ⬆️

[marcaaron]

I agree with @luacmartins and don't understand the benefits of having an input component that does this for us.

[thesahindia]

Yeah I agree on this too, I will update the PR and will remove the new component.

[thesahindia]

I have closed the previous PR ( needed to revert too many changes ) I have raised a new one https://github.com/Expensify/App/pull/8845

[kadiealexander]

Thanks for the update @thesahindia!

[marcaaron]

Going OOO for a week and will need to re-assign this.

[melvin-bot[bot]]

Current assignee @parasharrajat is eligible for the Exported assigner, not assigning anyone new.

[melvin-bot[bot]]

Triggered auto assignment to @neil-marcellini (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[neil-marcellini]

The PR is waiting to be deployed to staging. I'm commenting so that this doesn't go overdue.

[neil-marcellini]

I'm adding some labels that never got applied.

[melvin-bot[bot]]

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.1.60-3 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/8845

If no regressions arise, payment will be issued on 2022-05-23. :confetti_ball:

[thesahindia]

@kadiealexander, total compensation for this job is $750. $500 for the fix and $250 as the reporting bonus. Also please end the contract when you get time.

[kadiealexander]

@thesahindia yes, sorry about that I was just confirming the price change with our team. I've issued the remaining $250 and closed the contract.

@parasharrajat has now also been paid.