[HOLD for payment 2022-01-25] Category names in EmojiPicker are not translated - Reported by @mananjadhav

[mvtglobally]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open app
2. Set language to spanish
3. Check emoji picker in any chat
4. Note category names

Expected Result:

Category names in EmojiPicker should be translated

Actual Result:

Category names in EmojiPicker are not translated

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.1.26-0 Reproducible in staging?: Y Reproducible in production?: Y Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL: Issue reported by: @mananjadhav Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1640957759340100

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @jasperhuangg (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[mananjadhav]

Proposing the solution as I've reported and I am also working on other EmojiPicker issues.

1. We need to update all the code for headers in assets/emojis.js with their translation keys like smileysAndPeople, animalsAndNature.

2. Add the key-value pairs in en and es files under emojiPicker section with headers

   // example
   emojiPicker: {
    ...
    headers: {
       smileysAndPeople: 'Smileys and People'
       animalsAndNature: 'Animals and Nature',
   
    }
   }

3. In EmojiPicker component, where we have the header being rendered.

https://github.com/Expensify/App/blob/51de5d9ea050fa83a9ec0286e1806f51a1e20876/src/pages/home/report/EmojiPickerMenu/index.js#L342-L348

We replace {code} with

{this.props.translate(`emojiPicker.headers.${code}`)}

[MelvinBot]

Triggered auto assignment to @adelekennedy (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[jasperhuangg]

@mananjadhav has a good solution!

[adelekennedy]

Internal: https://www.upwork.com/ab/applicants/1479297672804737024/job-details External: https://www.upwork.com/jobs/~01d9f9b3536a1773f7

@mananjadhav I hired you for reporting the issue!

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (Exported)

[MelvinBot]

Triggered auto assignment to @stitesExpensify (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[rushatgabhane]

🎀👀🎀 C+ Reviewed

@stitesExpensify Let's go with @mananjadhav's proposal. It works and I don't see any issues with it

[stitesExpensify]

Yep I agree! Proposal looks good :smile:

[mananjadhav]

@stitesExpensify Anything else needed from me to be assigned this?

[adelekennedy]

@mananjadhav I don't think so! You're already hired for the job in Upwork and I've assigned you here - just noting for myself that you'll be paid the $250 reporting bonus on top of the project rate of $250!

[MelvinBot]

📣 @mananjadhav You have been assigned to this job by @adelekennedy! Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

[jasperhuangg]

@mananjadhav Feel free to request me for review once the PR is up!

[mananjadhav]

@jasperhuangg @rushatgabhane PR is raised.

[botify]

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.1.30-3 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/7125

If no regressions arise, payment will be issued on 2022-01-25. :confetti_ball:

[adelekennedy]

@mananjadhav just paid you out for the PR and reporting bonus, @rushatgabhane I hired you as well for the C+ fee!

[mananjadhav]

@adelekennedy Can we close this?