Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.46k stars 2.82k forks source link

[HOLD] FEATURE REQUEST: Add “remember this device for 30 days” functionality for 2FA code on New Dot like we do on Old Dot #7080

Closed mvtglobally closed 2 years ago

mvtglobally commented 2 years ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open app
  2. Sign in with 2FA enabled account
  3. Select “remember this device for 30 days”

Expected Result:

User should be able to remember device for 30 days

Actual Result:

There is no option to remember device

Workaround:

Unknown

Platform:

Where is this issue occurring?

Version Number: 1.1.26-0 Reproducible in staging?: Y Reproducible in production?: Y Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation Screen Shot 2022-01-07 at 12 52 14 AM

Expensify/Expensify Issue URL: Issue reported by: @puneetlath
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1641509655060100

View all open jobs on GitHub

MelvinBot commented 2 years ago

Triggered auto assignment to @mallenexpensify (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

mallenexpensify commented 2 years ago

Checking with Puneet in thread https://expensify.slack.com/archives/C01GTK53T8Q/p1641864381267100?thread_ts=1641509655.060100&cid=C01GTK53T8Q

mallenexpensify commented 2 years ago

Putting on since our sessions are currently longer in NewDot so there's not a direct or immediate problem to solve.. yet. Puneet is checking on session length here https://stackoverflow.com/c/expensify/questions/11704 Been discussing in the slack thread too, so review that if interested https://expensify.slack.com/archives/C01GTK53T8Q/p1641509655060100

puneetlath commented 2 years ago

Let's just close this for now. We can decide to do it later if we're so inclined.