Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.45k stars 2.81k forks source link

[$500] - Chat Room - Handle API response inVBA flow when tapping finish Set up #7185

Closed kbecciv closed 2 years ago

kbecciv commented 2 years ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to https://staging.new.expensify.com
  2. Log in with expensifail account
  3. Find any room in LHN
  4. Tap on plus button and tap Send Money
  5. Select amount and user
  6. Tap Pay with Expensify
  7. Tap Add Bank Account
  8. Put Wells Fargo credentials
  9. Select Saving Account
  10. Put Password and Tap Finish Set up

Expected Result:

If the API request fails, we handle that and show the error to the user.

Actual Result:

Unable procced with VBA flow after put password and tap finish Set up. No error shown.

Workaround:

Unknown

Platform:

Where is this issue occurring?

Version Number: 1.1.29.1

Reproducible in staging?: Yes

Reproducible in production?: No

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:

Issue reported by: Applause

https://user-images.githubusercontent.com/93399543/149238337-c6759873-2ae1-4df7-ae90-a17a81a0f866.mp4

Slack conversation:

View all open jobs on GitHub

parasharrajat commented 1 year ago

Bump @Christinadobrzyn :arrow_up:

parasharrajat commented 1 year ago

@Christinadobrzyn Any update for me?

chiragsalian commented 1 year ago

Hi @Expensify/contributor-management, can someone help out with the payment here?

puneetlath commented 1 year ago

Paid it @parasharrajat. Just to confirm, there was no C+ on this?

parasharrajat commented 1 year ago

Yeah, no C+. Thanks.