[$250] Unclear error displayed if user tries to pay IOU for deleted account request - reported by @Tushu17

[mvtglobally]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Request money from Account A to account B
2. Close account A

Expected Result:

We handle it pretty badly today (see the actual result) which is an oversight. Following the discussion in this thread, we’re going to prevent it like such:

• When someone is attempting to close an account and they have an iouReport with an outstanding balance (i.e not $0), we’ll show an “Are you sure?” confirmation modal to highlight that
• If they proceed with the action of closing their account, any outstanding money requests will be rejected (“cancelled” or “declined”)

In doing so, we’ll resolve the problems we’re seeing in this issue, as there wouldn’t be a case whereby someone is seeing a “Pay” button on a request from a member with a closed account, because we rejected them when they took the action to close their account.

Flow:

1. Member has an iouReport with an outstanding balance (i.e not $0) to settle or be paid back
2. Navigates to Security > Close account
3. Enters email address > click “Close account”
4. An “Are you sure?” confirmation modal appears: “If you proceed with this action, any outstanding money requests will be cancelled or declined.”
5. Click “Yes, close my account”
6. The requests are cancelled/declined adding the reportAction messages to the DM as normal

Mocks: [TBD - need to add]

Actual Result:

Unclear error displayed and user is unable to pay

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Notes/Photos/Videos: Any additional supporting documentation

https://user-images.githubusercontent.com/43995119/151295657-ec6f240f-5545-4583-ab34-74d612a37f42.mp4

Issue reported by: @Tushu17 Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1642285631499100

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @mateocole (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[mateocole]

Question on this, do we allow Account A to close if there are pending payments?

[Tushu17]

@mateocole Yes, We allow usersto delete their account even if they have pending payments.

[MelvinBot]

This issue has not been updated in over 14 days. @mateocole eroding to Weekly issue.

[MelvinBot]

Triggered auto assignment to @deetergp (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[deetergp]

Not sure how this flew under the radar, but it can be worked on by an external contributor.

[melvin-bot[bot]]

Triggered auto assignment to @MitchExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[MitchExpensify]

Exported to Upwork and @Tushu17 invited for eventual reporting bonus payment

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (Exported)

[melvin-bot[bot]]

Current assignee @deetergp is eligible for the Exported assigner, not assigning anyone new.

[Tushu17]

@MitchExpensify Sorry I almost forgot and applied to the job. Actually there's a similar issue(#7420) for this and I think this will get fixed there, so I think we should hold this one if it doesn't get fixed we can remove the hold.

[MitchExpensify]

Sounds like a plan @Tushu17

[MitchExpensify]

Holding on https://github.com/Expensify/App/issues/7420 to see if it fixes this issue once deployed

[deetergp]

Not overdue, just holding

[deetergp]

Still holding…

[rushatgabhane]

Unassigning myself because I'm OOO until May 14

[deetergp]

Same status as the last. Once @stitesExpensify sorts out https://github.com/Expensify/App/issues/7420, we'll re-test this one to see if it's fixed.

[MitchExpensify]

Waiting on #7420 to re-test

[MitchExpensify]

Same as above

[deetergp]

Still on hold

[deetergp]

Still holding?

[deetergp]

How long are we going to hold on this one?

[stitesExpensify]

We're holding until I do this issue, which is currently very low priority.

[deetergp]

Still holding. Since @stitesExpensify's blocking issue is low priority, going to set this to monthly.

[MitchExpensify]

Still holding on https://github.com/Expensify/App/issues/7420

[deetergp]

No updates as yet.

[deetergp]

Not overdue

[deetergp]

Still on hold

[tjferriss]

Following instructions for the weekly update chore:

@deetergp this is one of the oldest issues in the /App repo. To help us clear out the large backlog of bugs, can you:

• Decide whether any proposals currently meet our guidelines and can be approved as-is
• For any that can't, please take this issue internal and treat it as one of your highest priorities
• If you have any questions, don't hesitate to start a discussion in #bug-zero

I recognize this issue is on hold so maybe the above is irrelevant, but once it's not on hold do you expect we should take this internal given the issue's age?

[deetergp]

Actually, it looks like the issue this was holding on has been merged, paid, and closed. Going to take it off hold and request another re-test from @mvtglobally in #qa and see if it's still broken.

[mvtglobally]

@deetergp I am getting slightly different error now, but still an error without clear explanation

https://user-images.githubusercontent.com/43995119/204436211-0fccac45-7a22-4e66-b9bd-de4ebcfbfd46.mp4

[MitchExpensify]

Actually, it looks like the issue this was holding on has been merged, paid, and closed. Going to take it off hold and request another re-test from @mvtglobally in #qa and see if it's still broken.

Updated the title to reflect this

[deetergp]

I'm just going to remove external and take this one on.

[JmillsExpensify]

Awesome, sounds great! This is the second-oldest open issue in the repo without a PR. Now's a good time to close the loop on it.

[melvin-bot[bot]]

A Contributor Manager will be assigned to issue payment via Upwork if we deploy an associated Pull Request to production. Per Contributing.md.

[deetergp]

On my first few tries to recreate this, I got different results, but am now able to recreate @mvtglobally's results. I'm also noticing a not-particuarly-useful-for-end-users error in the middle of the screen when User B navigates to their convo with User A after the latter has closed their account. That same error is present in Maria's video, so at least it's consistent!

[JmillsExpensify]

Wowsers, that is indeed a not very useful RBR error message. We need to fail more gracefully here.

[MitchExpensify]

Discussion ongoing here

[MitchExpensify]

@Tushu17 Invited you to the new Upwork Job for reporting bonus payment

[Tushu17]

Hello @MitchExpensify, I'm already compensated for #7420, Which we were assuming will fix this issue too. So Ig you don't need to pay me reporting bonus for this issue.

[JmillsExpensify]

Thanks so much for your honesty! @MitchExpensify With that in mind, I think we're set to close this issue out, right?

[MitchExpensify]

Yes @JmillsExpensify! Closing. And thanks @Tushu17, much appreciated

[MitchExpensify]

And just as a note for posterity. This is closed because we evaluated the expected behavior in this Slack thread resulting in us creating two new issues:

1. Decline/cancel all outstanding IOUs on account close
2. Extend “archive” pattern to DMs