search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.56k stars 2.9k forks source link

[HOLD for payment 2022-05-20] [$4,000] Web - Workspace- New capability to set tracking rate and unit persists after page refresh #7573

Closed kbecciv closed 2 years ago

kbecciv commented 2 years ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Precondition: Add the VBA into your testing account

  1. Launch the app
  2. Log in with expensiafail account
  3. Go to Setting
  4. Select any Workspace
  5. Go to Reimburse expenses
  6. Refresh the pages

Expected Result:

New capability to set tracking rate and unit appears when go to reimburse expense page

Actual Result:

Tracking rate and unit does not appear and appears for a brief moment when refreshing the page.

Workaround:

Unknown

Platform:

Where is this issue occurring?

Version Number: 1.1.36.0

Reproducible in staging?: Yes

Reproducible in production?: No

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

https://user-images.githubusercontent.com/93399543/152598163-121bfbea-ed3d-44a1-9159-4f4408e5eab8.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause

Slack conversation:

Issue was found when executing: https://github.com/Expensify/App/pull/6839

View all open jobs on GitHub

Julesssss commented 2 years ago

Okay, let's get you both assigned, @parasharrajat as C+ to ensure the PR gets a proper review

melvin-bot[bot] commented 2 years ago

📣 @mateusbra You have been assigned to this job by @Julesssss! Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

mateusbra commented 2 years ago

Proposal sent on Upwork! Gonna rise a PR soon.

cc: @stephanieelliott

mateusbra commented 2 years ago

PR ready for review.

mvtglobally commented 2 years ago

Issue not reproducible during KI retests. (First week)

parasharrajat commented 2 years ago

PR deployed to PROD 3 days back. Can someone update the title? It seems the PR author did not use the link correctly.

Julesssss commented 2 years ago

Hey @NicMendonca can we please pay out on the 20th

Also @parasharrajat, what exactly do we need to update? The $4000 bounty looks right to me, but please correct me if I missed something.

parasharrajat commented 2 years ago

The title needs to be updated to have [HOLD for payment date]

Julesssss commented 2 years ago

Ah, gotcha. Thanks

mvtglobally commented 2 years ago

Issue not reproducible during KI retests. (Second week)

parasharrajat commented 2 years ago

@NicMendonca Ping for Upwork

NicMendonca commented 2 years ago

paid! Sorry for the delay!