[HOLD for payment 2022-05-20][$2000] Copying / pasting code between < and /> seems broken

mvtglobally commented 2 years ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Type something like and send the message
Try to select, copy, then paste into a new message

Expected Result:

Exactly what you copied should be pasted

Actual Result:

The code gets stripped Issue happens when selecting with a mouse, not when using the Copy button

Workaround:

unknown

Platform:

Where is this issue occurring?

Web
iOS
Android
Desktop App
Mobile Web

Version Number: 1.1.40-0 Reproducible in staging?: Y Reproducible in production?: Y Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation

https://user-images.githubusercontent.com/43995119/155665755-5ae5607a-9621-4cb0-bf88-3606dd32f313.mov

Expensify/Expensify Issue URL: Issue reported by: @Beamanator Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1644856333330159

View all open jobs on GitHub

MelvinBot commented 2 years ago

Triggered auto assignment to @iwiznia (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

MelvinBot commented 2 years ago

Triggered auto assignment to @adelekennedy (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

mateusbra commented 2 years ago

PROPOSAL

We have to change how we strip html when copying to clipboard, at the moment we are only replacing everything within <> for an empty string here: https://github.com/Expensify/expensify-common/blob/f77bb4710c13d01153716df7fb087b637ba3b8bd/lib/str.js#L306-L318

adelekennedy commented 2 years ago

internal external

MelvinBot commented 2 years ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (Exported)

MelvinBot commented 2 years ago

Triggered auto assignment to @puneetlath (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

parasharrajat commented 2 years ago

Thanks for the proposal @mateusbra. Could you please root cause details to your proposal? and tell us how did you reach your solution.

dennismunene commented 2 years ago

PROPOSAL

We need to change how we handle pasted HTML here.

Change this

https://github.com/Expensify/expensify-common/blob/f77bb4710c13d01153716df7fb087b637ba3b8bd/lib/str.js#L312-L318

To

Only strip off valid html tags

    /**
     * Gets the textual value of the given string.
     *
     * @param {String} str The string to fetch the text value from.
     * @return {String} The text from within the HTML string.
     */
    stripHTML(str) {
        if (!this.isString(str)) {
            return '';
        }

        return str.replace(/<\/?(a|abbr|acronym|address|applet|area|article|aside|audio|b|base|basefont|bdi|bdo|bgsound|big|blink|blockquote|body|br|button|canvas|caption|center|cite|code|col|colgroup|data|datalist|dd|del|details|dfn|dir|div|dl|dt|em|embed|fieldset|figcaption|figure|font|footer|form|frame|frameset|h1|h2|h3|h4|h5|h6|head|header|hgroup|hr|html|i|iframe|img|input|ins|isindex|kbd|keygen|label|legend|li|link|listing|main|map|mark|marquee|menu|menuitem|meta|meter|nav|nobr|noframes|noscript|object|ol|optgroup|option|output|p|param|plaintext|pre|progress|q|rp|rt|ruby|s|samp|script|section|select|small|source|spacer|span|strike|strong|style|sub|summary|sup|table|tbody|td|textarea|tfoot|th|thead|time|title|tr|track|tt|u|ul|var|video|wbr|xmp|path|svg|...)\b[^<>]*>/g, '');
    },

SCREEN RECORDING

https://user-images.githubusercontent.com/4717301/155875274-e12f58b4-d934-4a93-b3b7-bfe7df2cbc84.mov

parasharrajat commented 2 years ago

Thanks for the proposal @dennismunene. Did you try?

 `<someComponent />`

as message.

dennismunene commented 2 years ago

@parasharrajat yes I have , works as expected.

parasharrajat commented 2 years ago

Ok. Thanks but I don't consider this a proper approach.

const parser = new ExpensiMark(); 
     const markdownText = parser.htmlToMarkdown(html);

This step is important for the app.

dennismunene commented 2 years ago

@parasharrajat updated my proposal.

parasharrajat commented 2 years ago

Thanks, @dennismunene but I still think we can do better.

StripHTML is doing its job of removing HTML but the question is why are getting HTML at this stage? HTML should have been converted to MD by now.

Now there are two things to compare.

Copy to clipboard and Selection copy via Ctrl+C.

Copy to clipboard works. But the selection does not. So it must have given you the idea by now what is wrong.

mateusbra commented 2 years ago

Thanks for the proposal @mateusbra. Could you please root cause details to your proposal? and tell us how did you reach your solution.

@parasharrajat thank you for the review. I think this is gonna be more complex than I thought, please ignore my proposal by now

MelvinBot commented 2 years ago

Current assignee @parasharrajat is eligible for the Exported assigner, not assigning anyone new.

MelvinBot commented 2 years ago

Current assignee @adelekennedy is eligible for the External assigner, not assigning anyone new.

MelvinBot commented 2 years ago

Triggered auto assignment to @marcaaron (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

puneetlath commented 2 years ago

@marcaaron I'm about to head out on my two-month sabbatical, so handing this off to you. Thanks!

marcaaron commented 2 years ago

Still waiting for a proposal.

adelekennedy commented 2 years ago

Doubling the issue!

adelekennedy commented 2 years ago

Not overdue - just doubled the issue 4 days ago

MelvinBot commented 2 years ago

@parasharrajat, @marcaaron, @adelekennedy Whoops! This issue is 2 days overdue. Let's get this updated quick!

marcaaron commented 2 years ago

🦗

adelekennedy commented 2 years ago

Still no volunteers 😬 we're a day out from me doubling the issue

adelekennedy commented 2 years ago

🤑 doubled 🤑

marcaaron commented 2 years ago

Melv needs a spa day

Beamanator commented 2 years ago

Maybe this should be weekly 😅 ?

parasharrajat commented 2 years ago

In case someone is looking to solve this, https://github.com/Expensify/App/issues/7912#issuecomment-1053609946 indicates what needs to be done.

adelekennedy commented 2 years ago

We're at the mark to double the issue again! @parasharrajat you've pointed out how this issue can be resolved above @mateusbra and @dennismunene any interest in giving a proposal another go?

Big-Vi commented 2 years ago

Hi,

I just looked into this issue now. As mentioned in the previous comment, stripHTML function from expensify-common library strips out the text within <>.

https://github.com/Expensify/expensify-common/blob/main/lib/str.js#L312

Modifying the regex works fine. The video is attached below:

https://user-images.githubusercontent.com/30820063/160226276-a10e4167-b4c2-4c33-b0aa-cb42bb0e6e49.mov

I know the above solution works. but what if we take this opportunity to build a text formatting toolbar like slack(Video attached below):

https://user-images.githubusercontent.com/30820063/160227053-a9a44475-01f9-45e7-9df6-2108b7bd3c32.mov

With this approach basically, We would replace the input with Richtoolbar.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/barun1997"><img src="https://avatars.githubusercontent.com/u/19339044?v=4" />barun1997</a> commented <strong> 2 years ago</strong> </div> <div class="markdown-body"> <p>Edit: @brianmuks seems to have nailed it below. So retracting my proposal.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/brianmuks"><img src="https://avatars.githubusercontent.com/u/4520893?v=4" />brianmuks</a> commented <strong> 2 years ago</strong> </div> <div class="markdown-body"> <p><strong><em>Proposal</em></strong> The issue is coming from this line : <a href="https://github.com/Expensify/App/blob/b347866b2af95bd2c51eb6bb65098bd1d756e7d0/src/libs/SelectionScraper/index.js#L135">https://github.com/Expensify/App/blob/b347866b2af95bd2c51eb6bb65098bd1d756e7d0/src/libs/SelectionScraper/index.js#L135</a> Wrong html content is being passed to <code>parser.htmlToMarkdown(newHtml);</code> If you compare with what is being passed to : <a href="https://github.com/Expensify/App/blob/b347866b2af95bd2c51eb6bb65098bd1d756e7d0/src/pages/home/report/ContextMenu/ContextMenuActions.js#L69">https://github.com/Expensify/App/blob/b347866b2af95bd2c51eb6bb65098bd1d756e7d0/src/pages/home/report/ContextMenu/ContextMenuActions.js#L69</a></p> <p>When a user clicks on <code>copy to cliboard</code> for this code block : "<code><someComponent /></code>" what is being passed to <code>parser.htmlToMarkdown(newHtml);</code> is <code>'<code><someComponent /></code>'</code>. This is similar to the data coming from : <a href="https://github.com/Expensify/App/blob/b347866b2af95bd2c51eb6bb65098bd1d756e7d0/src/libs/actions/Report.js#L946">https://github.com/Expensify/App/blob/b347866b2af95bd2c51eb6bb65098bd1d756e7d0/src/libs/actions/Report.js#L946</a></p> <p><code>html: '<code><someComponent /></code>'</code></p> <p>With that said in order to pass the right format to <code>parser.htmlToMarkdown(newHtml);</code> when a user presses <code>CTR+C</code> we need to know what the original text looked like . To achieve this we need a new function to generate the text:</p> <pre><code> const getTextFromSelection = (selectionHtml) => { const div = document.createElement('div'); div.innerHTML = selectionHtml; //get the last child from parent node let lastNode = div.lastChild; let innerHTML = ''; //loop through the node until we get the content of the lastNode which has the original text while (lastNode && lastNode.hasChildNodes) { innerHTML = lastNode.innerHTML ? lastNode.innerHTML : innerHTML; lastNode = lastNode.lastChild; } return innerHTML; }</code></pre> <p>The results of <code>getTextFromSelection</code> is <code>" <someComponent />"</code> So all we are missing here is just a wrapper which can be obtained from the results of : <a href="https://github.com/Expensify/App/blob/b347866b2af95bd2c51eb6bb65098bd1d756e7d0/src/libs/SelectionScraper/index.js#L131">https://github.com/Expensify/App/blob/b347866b2af95bd2c51eb6bb65098bd1d756e7d0/src/libs/SelectionScraper/index.js#L131</a> the results of <code>render(domRepresentation);</code> is <code>"<code><span><someComponent /></span></code>"</code> At this point we just need to replace <code>"<someComponent />"</code> with the results from <code>getTextFromSelection</code> . <code>const newHtmlWithText = newHtml.replace(selection, originalText);</code> Now we can pass <code>newHtmlWithText</code> to <code>parser.htmlToMarkdown(newHtmlWithText);</code>.</p> <p>The modification of <code>getAsMarkdown</code> will be :</p> <pre><code>const getAsMarkdown = () => { const selectionHtml = getHTMLOfSelection(); const selection = window.getSelection(); const domRepresentation = parseDocument(selectionHtml); domRepresentation.children = _.map(domRepresentation.children, c => replaceNodes(c)); const newHtml = render(domRepresentation); const originalText = getTextFromSelection(selectionHtml); console.log(':domRepresentation', newHtml); //replace the the rendered text with the original text const newHtmlWithText = newHtml.replace(selection, originalText); const parser = new ExpensiMark(); return parser.htmlToMarkdown(newHtmlWithText); };</code></pre> <p><a href="https://user-images.githubusercontent.com/4520893/160298441-5eb4cd87-012d-4d41-8441-e38534a5eebf.mov">https://user-images.githubusercontent.com/4520893/160298441-5eb4cd87-012d-4d41-8441-e38534a5eebf.mov</a></p> <p><strong><em>Fun-Fact</em></strong> 😄 : I had a hard time typing this because even <code>github</code> renders <code>"<code><someComponent /></code>"</code> as <code>""</code>. </p> <p><a href="https://user-images.githubusercontent.com/4520893/160299224-dcb3c348-a936-4621-a163-70524fb9bed2.mov">https://user-images.githubusercontent.com/4520893/160299224-dcb3c348-a936-4621-a163-70524fb9bed2.mov</a></p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/brianmuks"><img src="https://avatars.githubusercontent.com/u/4520893?v=4" />brianmuks</a> commented <strong> 2 years ago</strong> </div> <div class="markdown-body"> <blockquote> <p>Edit: @brianmuks seems to have nailed it below. So retracting my proposal.</p> </blockquote> <p>Thanks @barun1997 </p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/parasharrajat"><img src="https://avatars.githubusercontent.com/u/24370807?v=4" />parasharrajat</a> commented <strong> 2 years ago</strong> </div> <div class="markdown-body"> <p>@barun1997 Thanks for the proposal. Could be please test your proposal against the following: </p> <p>Paste this in composer and send as a message.</p> <pre><code>> This is a quote > Mul *Bold* _italic_ https://google.com `yo yo code block` *bold inline* </code></pre> <p>On which fact are you proposing the string replacement as a fix? What is the base of this solution? </p> <pre><code> const originalText = getTextFromSelection(selectionHtml); console.log(':domRepresentation', newHtml); //replace the the rendered text with the original text const newHtmlWithText = newHtml.replace(selection, originalText);</code></pre> <p>Why does doing this solve the problem? Will it work in general with every tag? </p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/brianmuks"><img src="https://avatars.githubusercontent.com/u/4520893?v=4" />brianmuks</a> commented <strong> 2 years ago</strong> </div> <div class="markdown-body"> <p><strong>Edited</strong>: the function returns text not html. Thanks @parasharrajat My solution does not cover this scenario: <code>"Sentence with <code/> in it"</code> So I though of some minor modifications:</p> <pre><code>const getAsMarkdown = () => { const selectionHtml = getHTMLOfSelection(); const originalText = getTextFromSelection(selectionHtml); // const domRepresentation = parseDocument(selectionHtml); // domRepresentation.children = _.map(domRepresentation.children, c => replaceNodes(c)); // const newHtml = render(domRepresentation); const parser = new ExpensiMark(); return parser.htmlToMarkdown(originalText); };</code></pre> <pre><code>const getTextFromSelection = (selectionHtml) => { const div = document.createElement('div'); div.innerHTML = selectionHtml; let node = div; let text = ''; let counter = 0; //loop through the node until we get the content of the lastNode which has the original text while (node && node.hasChildNodes) { //ignore the content of first child as experiment shows that the main parent's //content is equal to the first child's content if (node && node.children && node.children.length && counter !== 1) { // console.log('nodeChildrenHasChild:' + node.children); var children = [].slice.call(node.children); children.forEach(child => { const container = { ...child.dataset }.testid; //if child is a code component wrap it in its original component text += container ? `<${container}>${child.innerHTML}</${container}>` : child.innerHTML; }); } node = node.lastChild; counter++; } return text; }</code></pre> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/parasharrajat"><img src="https://avatars.githubusercontent.com/u/24370807?v=4" />parasharrajat</a> commented <strong> 2 years ago</strong> </div> <div class="markdown-body"> <p>Could you please help with answers to my questions as well? Also, small(any) details will help me understand your plan. <a href="https://github.com/Expensify/App/issues/7912#issuecomment-1080342870">https://github.com/Expensify/App/issues/7912#issuecomment-1080342870</a> does not tell what are you trying to establish.</p> <p>The previous proposal suggests that you are proposing string replacement as a solution and in the new code snippet, your function <code>getTextFromSelection</code> is returning HTML. Why?</p> <p>Although you are looking at the correct place it seems you may have been distracted from the main solution here. I will suggest finding another simpler approach to the problem. </p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/brianmuks"><img src="https://avatars.githubusercontent.com/u/4520893?v=4" />brianmuks</a> commented <strong> 2 years ago</strong> </div> <div class="markdown-body"> <blockquote> <p>Could you please help with answers to my questions as well? Also, small(any) details will help me understand your plan. <a href="https://github.com/Expensify/App/issues/7912#issuecomment-1080342870">#7912 (comment)</a> does not tell what are you trying to establish.</p> <p>The previous proposal suggests that you are proposing string replacement as a solution and in the new code snippet, your function <code>getTextFromSelection</code> is returning HTML. Why?</p> <p>Although you are looking at the correct place it seems you may have been distracted from the main solution here. I will suggest finding another simpler approach to the problem.</p> </blockquote> <p>So what we are trying to achieve here is to extract/determine the original text that was saved to the database as <code>html</code>. The <code>copy to clipboard</code> function basically uses the <code>html</code> content and passes it to <code>parser.htmlToMarkdown(html);</code> then writes it to the clipboard. So I feel that the function handling <code>CTR+C</code> should be as similar as possible to the <code>copy to clipboard</code> function. </p> <p>If there was an easy way of extracting/determining the original <code>html</code> fetched from the database for a message from <code>getHTMLOfSelection();</code> then we could use that. </p> <p>By the way <code>copy to clipboard</code> fails to copy quotes properly. So I was wondering if we want to fix that all at once because I reported a bug for it few days ago.</p> <p><a href="https://user-images.githubusercontent.com/4520893/160365106-2f28baf3-49b4-4657-90a2-f9c7fa1d437a.mov">https://user-images.githubusercontent.com/4520893/160365106-2f28baf3-49b4-4657-90a2-f9c7fa1d437a.mov</a></p> <p>So far my latest solution works for tags . I am still looking at how to handle scenarios you asked me to test. <code>"> This is a quote"</code> <code>"> Mul"</code></p> <p><code>"*Bold* _italic_ https://google.com"</code></p> <p><code>"</code>yo yo code block<code>*bold inline*"</code></p> <p><a href="https://user-images.githubusercontent.com/4520893/160367877-cfbed48f-db44-4a52-b28d-9a74adaea9e2.mov">https://user-images.githubusercontent.com/4520893/160367877-cfbed48f-db44-4a52-b28d-9a74adaea9e2.mov</a></p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/parasharrajat"><img src="https://avatars.githubusercontent.com/u/24370807?v=4" />parasharrajat</a> commented <strong> 2 years ago</strong> </div> <div class="markdown-body"> <blockquote> <p>So what we are trying to achieve here is to extract/determine the original text that was saved to the database as html.</p> </blockquote> <p>Thanks for the explanation. It would be technically impossible with the current implementation of message parsing. Also, it does not seem like an elegant solution. </p> <blockquote> <p>text += container ? <code><${container}>${child.innerHTML}</${container}></code> : child.innerHTML;</p> </blockquote> <p>It does sound like HTML.</p> <blockquote> <p>By the way copy to clipboard fails to copy quotes properly. So I was wondering if we want to fix that all at once because I reported a bug for it a few days ago.</p> </blockquote> <p>we can only focus on solving the code blocks in a way that does not block or break others. </p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/gladiator-1"><img src="https://avatars.githubusercontent.com/u/102553449?v=4" />gladiator-1</a> commented <strong> 2 years ago</strong> </div> <div class="markdown-body"> <h3>Proposal</h3> <p>in src/libs/SelectionScraper :</p> <pre><code>const replaceNodes = (dom) => { + if (dom.type == "text") { + dom.data = dom.data.replaceAll('<', '<').replaceAll('>', '>') + } let domName = dom.name;</code></pre> <p>Result : </p> <p><a href="https://user-images.githubusercontent.com/102553449/160479316-26a46b18-9ebf-4ead-aa12-bf6d79901db7.mp4">https://user-images.githubusercontent.com/102553449/160479316-26a46b18-9ebf-4ead-aa12-bf6d79901db7.mp4</a></p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/parasharrajat"><img src="https://avatars.githubusercontent.com/u/24370807?v=4" />parasharrajat</a> commented <strong> 2 years ago</strong> </div> <div class="markdown-body"> <p>Thanks for the proposal @gladiator-1. It seems to do what we need here. Could you please confirm if we can use <code>Str.htmlEncode</code> here instead of manual replacement?</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/gladiator-1"><img src="https://avatars.githubusercontent.com/u/102553449?v=4" />gladiator-1</a> commented <strong> 2 years ago</strong> </div> <div class="markdown-body"> <p>@parasharrajat Sure</p> <pre><code> import {parseDocument} from 'htmlparser2'; import {Element} from 'domhandler'; import _ from 'underscore'; + import Str from 'expensify-common/lib/str'; const replaceNodes = (dom) => { + if (dom.type == "text") { + dom.data = Str.htmlEncode(dom.data) + } let domName = dom.name;</code></pre> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/parasharrajat"><img src="https://avatars.githubusercontent.com/u/24370807?v=4" />parasharrajat</a> commented <strong> 2 years ago</strong> </div> <div class="markdown-body"> <blockquote> <p>Could you please confirm if we can use <code>Str.htmlEncode</code> here instead of a manual replacement?</p> </blockquote> <p>Is it working fine without breaking other tags? </p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/gladiator-1"><img src="https://avatars.githubusercontent.com/u/102553449?v=4" />gladiator-1</a> commented <strong> 2 years ago</strong> </div> <div class="markdown-body"> <blockquote> <p>Is it working fine without breaking other tags?</p> </blockquote> <p>Yes</p> <p><a href="https://user-images.githubusercontent.com/102553449/160613681-4475a20a-f809-4f7a-a8fc-76789534417c.mp4">https://user-images.githubusercontent.com/102553449/160613681-4475a20a-f809-4f7a-a8fc-76789534417c.mp4</a></p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/parasharrajat"><img src="https://avatars.githubusercontent.com/u/24370807?v=4" />parasharrajat</a> commented <strong> 2 years ago</strong> </div> <div class="markdown-body"> <p>Thanks, I was really looking for a simpler approach like @gladiator-1 has presented. </p> <p>One improvement would be to do this manipulation at the parsing step <a href="https://github.com/fb55/htmlparser2#usage">onText</a>. </p> <p>Thanks, @barun1997 and @brianmuks for your efforts in looking into getting a proper solution. But I like @gladiator-1's simpler approach to the problem. <a href="https://github.com/Expensify/App/issues/7912#issuecomment-1081094208">https://github.com/Expensify/App/issues/7912#issuecomment-1081094208</a> <a href="https://github.com/Expensify/App/issues/7912#issuecomment-1081733070">https://github.com/Expensify/App/issues/7912#issuecomment-1081733070</a></p> <p>cc: @marcaaron </p> <p>:ribbon: :eyes: :ribbon: C+ reviewed</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/gladiator-1"><img src="https://avatars.githubusercontent.com/u/102553449?v=4" />gladiator-1</a> commented <strong> 2 years ago</strong> </div> <div class="markdown-body"> <blockquote> <p>One improvement would be to do this manipulation at the parsing step <a href="https://github.com/fb55/htmlparser2#usage">onText</a>.</p> </blockquote> <p>Excuse me, Is it possible to update the parsed document object at the parsing step ?</p> <p><code>const domRepresentation = parseDocument(selectionHtml)</code></p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/parasharrajat"><img src="https://avatars.githubusercontent.com/u/24370807?v=4" />parasharrajat</a> commented <strong> 2 years ago</strong> </div> <div class="markdown-body"> <p>I looked at the wrong name. It seems not, then your proposal is fine. </p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/adelekennedy"><img src="https://avatars.githubusercontent.com/u/60450566?v=4" />adelekennedy</a> commented <strong> 2 years ago</strong> </div> <div class="markdown-body"> <p>@gladiator-1 I'm struggling to find you in Upwork, do you mind applying for the job <a href="https://www.upwork.com/jobs/~01c90fb0c06dde1e5c">here</a>?</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/gladiator-1"><img src="https://avatars.githubusercontent.com/u/102553449?v=4" />gladiator-1</a> commented <strong> 2 years ago</strong> </div> <div class="markdown-body"> <p>@adelekennedy applied with code : 75340</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/MelvinBot"><img src="https://avatars.githubusercontent.com/u/12432488?v=4" />MelvinBot</a> commented <strong> 2 years ago</strong> </div> <div class="markdown-body"> <p>📣 @gladiator-1 You have been assigned to this job by @adelekennedy! Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: <a href="https://github.com/Expensify/App/blob/main/CODE_OF_CONDUCT.md">Code of Conduct</a> | <a href="https://github.com/Expensify/App/blob/main/CONTRIBUTING.md">Contributing</a> 📖</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/gladiator-1"><img src="https://avatars.githubusercontent.com/u/102553449?v=4" />gladiator-1</a> commented <strong> 2 years ago</strong> </div> <div class="markdown-body"> <p>@parasharrajat PR ready <a href="https://github.com/Expensify/App/pull/8449">https://github.com/Expensify/App/pull/8449</a></p> </div> </div> <div class="page-bar-simple"> <a href="/Expensify/App/7912?page=2" class="next">Next</a> </div> <div class="footer"> <ul class="body"> <li>© <script> document.write(new Date().getFullYear()) </script> Githubissues.</li> <li>Githubissues is a development platform for aggregating issues.</li> </ul> </div> <script src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js"></script> <script src="/githubissues/assets/js.js"></script> <script src="/githubissues/assets/markdown.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/highlight.min.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/languages/go.min.js"></script> <script> hljs.highlightAll(); </script> </body> </html>

Expensify / App