search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.14k stars 2.64k forks source link

Deploy Checklist: New Expensify 2022-03-01 #7954

Closed OSBotify closed 2 years ago

OSBotify commented 2 years ago

Release Version: 1.1.41-6 Compare Changes: https://github.com/Expensify/App/compare/production...staging

This release contains changes from the following pull requests:

Internal QA:

Deploy Blockers:

cc @Expensify/applauseleads

OSBotify commented 2 years ago

:rocket: All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.1.41-0 :rocket:

roryabraham commented 2 years ago

Web deploy failed, hopeful fix here

OSBotify commented 2 years ago

:clap: Heads up @Expensify/applauseleads :clap: A new pull request has been :cherries: cherry-picked :cherries: to staging, and will be deployed to staging in version 1.1.41-1 :rocket:

OSBotify commented 2 years ago

:tada: All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.41-1 has been deployed to staging :tada:

mvtglobally commented 2 years ago

@roryabraham if we are 1.1.40-0 on other platforms, can we start QA tests?

roryabraham commented 2 years ago

@mvtglobally no we should be at least 1.1.41-0 on all platforms ... but 1.1.41-1 should be available now?

mvtglobally commented 2 years ago

Sorry typo , I meant to say 1.1.41-0. We don't need to wait for -1, right?

Web is available 1.1.41-1, Desktop and IOS not yet

roryabraham commented 2 years ago

Correct, 1.1.41-0 is a high enough version because the diff between 41-0 and 41-1 is just related to building our (storybook) documentation site, not the actual application.

marcaaron commented 2 years ago

Checking off #7767 after testing on staging

mvtglobally commented 2 years ago

@roryabraham Desktop staging app is still 1.1.40-2 Screen Shot 2022-03-02 at 9 53 23 AM

roryabraham commented 2 years ago

Checked off https://github.com/Expensify/App/pull/7933 and https://github.com/Expensify/App/pull/7939 because they were deployed with the last checklist. I think it's a bug that they showed up here, but I don't have time to look into it right now unfortunately.

@roryabraham Desktop staging app is still 1.1.40-2

Oh, @mvtglobally, that's not good. This is potentially because of https://github.com/Expensify/App/pull/7744 cc @kidroca. It might also just be because of https://github.com/Expensify/App/pull/7765, which increase the interval at which NewDot check for updates from 1 hour to 8 hours.

kidroca commented 2 years ago

What happens after Desktop is built? @roryabraham can the changed folder cause an issue? - the Desktop app output is no longer in dist but in desktop-build Otherwise we're now build for 3 target x86, arm64 and universal apps, could that be a problem? We used to build only x86 before

I've examined the build script and was left under the impressions that publishing is handled by electron-builder as part of the build process - if it fails there would be a bang (I suppose)

Can you manually download or force update Desktop?

Should be there:

Could it be the lack of this zip? uploading file=New Expensify-1.1.40-2-mac.zip provider=S3

(If we enable it, it would make a zip for each platform and take more space...)

mvtglobally commented 2 years ago

@roryabraham do you need a bug for this build issue?

roryabraham commented 2 years ago

@roryabraham do you need a bug for this build issue?

Yes please

OSBotify commented 2 years ago

:clap: Heads up @Expensify/applauseleads :clap: A new pull request has been :cherries: cherry-picked :cherries: to staging, and will be deployed to staging in version 1.1.41-2 :rocket:

OSBotify commented 2 years ago

:tada: All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.41-2 has been deployed to staging :tada:

OSBotify commented 2 years ago

:clap: Heads up @Expensify/applauseleads :clap: A new pull request has been :cherries: cherry-picked :cherries: to staging, and will be deployed to staging in version 1.1.41-3 :rocket:

OSBotify commented 2 years ago

:tada: All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.41-3 has been deployed to staging :tada:

OSBotify commented 2 years ago

:clap: Heads up @Expensify/applauseleads :clap: A new pull request has been :cherries: cherry-picked :cherries: to staging, and will be deployed to staging in version 1.1.41-4 :rocket:

OSBotify commented 2 years ago

:tada: All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.41-4 has been deployed to staging :tada:

roryabraham commented 2 years ago

https://github.com/Expensify/App/issues/7987 is resolved and desktop staging builds/auto-update should be working again.

OSBotify commented 2 years ago

:clap: Heads up @Expensify/applauseleads :clap: A new pull request has been :cherries: cherry-picked :cherries: to staging, and will be deployed to staging in version 1.1.41-5 :rocket:

OSBotify commented 2 years ago

:tada: All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.41-5 has been deployed to staging :tada:

mvtglobally commented 2 years ago

Comments left. https://github.com/Expensify/App/pull/7662#issuecomment-1055849471 https://github.com/Expensify/App/pull/7594#issuecomment-1060162234 https://github.com/Expensify/App/pull/7922#issuecomment-1060166358

PR #7744 is failing due to #8014 PR #7805 is failing due to #8015 PR #7891 is failing due to #7980

Checking off #7879 as #7982 was closed Checking off #7996 & #7989 verified it is autoupdated and fixed

francoisl commented 2 years ago

Hi @mvtglobally, for the last two comments you left (https://github.com/Expensify/App/pull/7594#issuecomment-1060162234 and https://github.com/Expensify/App/pull/7922#issuecomment-1060166358), someone left a suggestion here explaining how to test.

francoisl commented 2 years ago

Adding https://github.com/Expensify/App/issues/8014 as a deploy blocker pending more investigation, because the desktop app seems to be broken/uninstallable.

francoisl commented 2 years ago
mvtglobally commented 2 years ago

Checking off #7594 and #7922

mvtglobally commented 2 years ago

@francoisl the following items are pending to close this checklist.

We are re-checking https://github.com/Expensify/App/pull/7662 based on new test steps Can we check off PR https://github.com/Expensify/App/pull/7744 as https://github.com/Expensify/App/issues/8014 no longer marked a blocker? PR https://github.com/Expensify/App/pull/7805 is failing due to https://github.com/Expensify/App/issues/8015 Checking off PR https://github.com/Expensify/App/pull/7891 as https://github.com/Expensify/App/issues/7980 is not a blocker We tested new PR https://github.com/Expensify/App/pull/8011. It is failing due to https://github.com/Expensify/App/issues/8040. This was working before.something reverted old fix.

francoisl commented 2 years ago

Noted, thanks. Looking into the remaining open issues now.

Can we check off PR https://github.com/Expensify/App/pull/7744 as https://github.com/Expensify/App/issues/8014 no longer marked a blocker?

Yes, let's check it off.

francoisl commented 2 years ago

And I think these are the last 2 remaining items once #7662 is checked again!

mvtglobally commented 2 years ago

Checking off #7662

OSBotify commented 2 years ago

:clap: Heads up @Expensify/applauseleads :clap: A new pull request has been :cherries: cherry-picked :cherries: to staging, and will be deployed to staging in version 1.1.41-6 :rocket:

OSBotify commented 2 years ago

:tada: All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.41-6 has been deployed to staging :tada:

TomatoToaster commented 2 years ago

https://github.com/Expensify/App/issues/8040 should be fixed now so I think the deploy is no longer blocked.

One issue is that the icons will be small for room details:

image

This will be fixed immediately on the next staging deploy when this PR is deployed to staging: https://github.com/Expensify/App/pull/7852 after which this will be merged making the icons bigger again https://github.com/Expensify/App/pull/8058

so the small icons should not block the deploy.

francoisl commented 2 years ago

@mvtglobally can you please:

mvtglobally commented 2 years ago

@francoisl

checking off #8011 its a pass

7805 is not repro in PROD.

isagoico commented 2 years ago

@roryabraham @francoisl - Looks like the only thing missing from the checklist is this Deploy Blocker https://github.com/Expensify/App/issues/8015 (issue is not reproducible in prod, confirmed above) any chance that can be looked at and probably get a deploy today? 🥺

francoisl commented 2 years ago

Still trying to consistently reproduce the issue. To clarify, are you only getting the blank screen when you sign in the account rybkina@gmail.com? And is that a personal account, or a test account you would be willing to share (i.e. add it to 1Password?)

I tested with different accounts, and the app takes at most 10 to 12 seconds to start rendering chat data in large accounts, both with the staging and production app. The only difference I see with the account rybkina@gmail.com is that it has a lot of IOUs. I asked around if we have test accounts with a lot of IOUs, but if you'd be willing to share the credentials for rybkina@gmail.com in the meantime, that would be helpful.

francoisl commented 2 years ago

Thanks, I ran some tests and can't see a lot of differences so I'm curious for second opinions from anyone else here. Let's keep the discussion in the GH issue though.

Once we're all done testing, can you please rotate the password of that account @mvtglobally? I know it's just a test account, but this is a public repo, so let's make sure the account won't be used for spam or shady stuff (I'm also deleting the previous comment as an extra precaution).

francoisl commented 2 years ago

Removed the deploy blocker label from #8015 since we're also seeing the same behavior with the production app. We'll keep the issue open so it can be looked further into though, given that it's pretty bad that the desktop app takes so long to load.

This was the last checkbox so we can go ahead with the deploy!

francoisl commented 2 years ago

:shipit:

Stutikuls commented 2 years ago

Checked all PRs and added comments to all PRs where accessibility issues were found without the Android platform (due to build issues on Android) only one issue is left and have query on https://github.com/Expensify/App/pull/7864 The non-applicable PRs are - https://github.com/Expensify/App/pull/7594, https://github.com/Expensify/App/pull/7662, https://github.com/Expensify/App/pull/7701, https://github.com/Expensify/App/pull/7744, https://github.com/Expensify/App/pull/7805, https://github.com/Expensify/App/pull/7827 Impossibility to verify (After client confirmation) - https://github.com/Expensify/App/pull/7804

SumitDiyora commented 2 years ago

Checked all PRs and added comments to all PRs where accessibility issues were found. The non-applicable PRs are - #7892, #7898, #7922, #7924, #7927, #7939, #7955, #7989, #7996, #8000