search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.34k stars 2.77k forks source link

[HOLD for payment 2022-06-16] [HOLD for payment 2022-06-15] [$500] Uploading an image causes the thumbnail to resize 3 times #8590

Closed mvtglobally closed 2 years ago

mvtglobally commented 2 years ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

  1. Open any chat
  2. Upload a larger file to share

Expected Result:

Thumbnail should load once uploaded, or if it's a large file it should display a spinner until it's uploaded.

Actual Result:

If you share an image, the uploading thumbnail resizes 3 times. Then it finalizes the upload.

Workaround:

Just wait for the file to upload but it's a jarring experience.

Platform:

Where is this issue occurring?

Version Number: 1.1.52-0 Reproducible in staging?: Y Reproducible in production?: Y Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation

If you click + > add attachment in a DM, and then select this attachment:

image - 2022-04-11T013155 286

You'll notice it changes to this momentarily:

image - 2022-04-11T013153 923

And then this:

image - 2022-04-11T013152 050

Upwork job URL: https://www.upwork.com/jobs/~01ca59e5811fecf4d5 Issue reported by: @cead22 Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1649352167230159

View all open jobs on GitHub

michaelhaxhiu commented 2 years ago

@allroundexperts is paid.

@Santhosh-Sellavel can you apply for this upwork job? the OG link expired

Santhosh-Sellavel commented 2 years ago

@michaelhaxhiu Applied for the job!

michaelhaxhiu commented 2 years ago

All are paid.

allroundexperts commented 1 year ago

The changes that you’re mentioning are IMO out of scope for this particular bug and will just take too much time for me. The original bug was that the image was being resized thrice. That thing is fixed. Your request can be looked upon in a separate feature request.

On Tue, 24 May 2022 at 10:59 PM, Sibtain Ali @.***> wrote:

These were discussed in the beginning as well but given how code is structured it won’t be easy to do these. Also, this would only work for the uploader of the image. The other users in the chat would still have to see a loader.

On Tue, 24 May 2022 at 10:46 PM, Carlos Alvarez @.***> wrote:

The thumbnails from step 1 and 3 are the same and i was wondering if the loading gif is a bad user experience or not

I think the video already shows an improvement from what we already have, but I do think showing the spinner is not ideal. Do either of these two options seem feasible and worth exploring?

  • One idea would be to display preview, upload the image, once that's done we create an invisible image element, and once it finishes loading (img.onload) we can swap the preview with the invisible image
  • Another is to display the preview, upload the image, once that's done we create an image element that's underneath the preview, and once it finishes loading (img.onload) we can remove the preview to reveal the image underneath

— Reply to this email directly, view it on GitHub https://github.com/Expensify/App/issues/8590#issuecomment-1136256236, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHFJUUCISGJIS3JC7SVP4CDVLUIW3ANCNFSM5TCA4OKQ . You are receiving this because you were mentioned.Message ID: @.***>