search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.46k stars 2.82k forks source link

[$500] Closing a modal navigates back to the OldDot transition #8601

Closed neil-marcellini closed 2 years ago

neil-marcellini commented 2 years ago

This PR for Web Expensify will fix this issue by opening the transitions in a new tab, but it would be good to fix this issue so that we can transition in the same tab. If this PR has already been merged, undo the changes locally to reproduce this issue.

Action Performed:

  1. Go to OldDot and sign up for a new account with an @gmail.com address
  2. Click on the "Get started" on the inbox task that says "Would you like to get started with our free plan?".
  3. Sign out of NewDot
  4. Go back to the OldDot inbox and refresh the page
  5. Click "Continue setup" on the inbox task that says "Finish setting up your bank account".
  6. After the "Connect bank account" modal page opens in the RHN, hit back or close

Expected Result:

The "Connect bank account" modal closes and the home screen is displayed

Actual Result:

The user is navigated back to the OldDot transition page.

Workaround:

Open NewDot in a new tab and navigate there.

Platform:

Version Number: v1.1.52-0 Reproducible in staging?: yes Reproducible in production?: yes Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation Expensify/Expensify Issue URL: Issue reported by: Slack conversation:

View all open jobs on GitHub

melvin-bot[bot] commented 2 years ago

Triggered auto assignment to @miljakljajic (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

melvin-bot[bot] commented 2 years ago

Triggered auto assignment to @timszot (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

timszot commented 2 years ago

@neil-marcellini is this something that could be external? It sounds like it might be an internal issue to me, but I might be missing something here.

neil-marcellini commented 2 years ago

I think it could be external since I'm pretty sure it has to do with React navigation.

melvin-bot[bot] commented 2 years ago

Triggered auto assignment to @arielgreen (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

arielgreen commented 2 years ago

https://www.upwork.com/jobs/~01b5bd589c6d58aeb0

melvin-bot[bot] commented 2 years ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (Exported)

melvin-bot[bot] commented 2 years ago

Triggered auto assignment to @flodnv (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

arielgreen commented 2 years ago

Increased price

aldo-expensify commented 2 years ago

Considering this message, I'm closing this and keeping https://github.com/Expensify/App/issues/8723 because it is more clear in describing the real bug.