search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.59k stars 2.92k forks source link

[HOLD for payment 2022-12-08] [$250][Form Refactor] CompanyStep #9580

Closed luacmartins closed 1 year ago

luacmartins commented 2 years ago

Coming from the New Expensify Forms design doc, we should refactor CompanyStep to use the new form component, follow the guidelines below:

Here's an example of a Form refactor: https://github.com/Expensify/App/pull/9056

Guidelines

  1. Replace the form component with Form.js.
  2. Create a unique Onyx key in ONYXKEYS.FORM and pass it as the formID prop to Form.
  3. Pass a validate callback prop.
  4. Pass an onSubmit callback prop that calls the API via an action.
  5. Update all inputs wrapped by Form, following the guidelines in Refactor inputs.
  6. Remove any unused code.

Testing

Verify that:

ravindra-encoresky commented 2 years ago

@mananjadhav https://github.com/Expensify/App/pull/10741 @luacmartins @sketchydroide

adelekennedy commented 2 years ago

@mananjadhav @ravindra-encoresky I know we had a lot of back and forth here are we just waiting for this PR to merge now?

mananjadhav commented 2 years ago

Waiting on @ravindra-encoresky to work on the feedback. Then one round of review + testing should be good to merge

melvin-bot[bot] commented 2 years ago

@sketchydroide, @mananjadhav, @ravindra-encoresky, @adelekennedy Whoops! This issue is 2 days overdue. Let's get this updated quick!

sketchydroide commented 2 years ago

this is being reviewed and worked on right now.

sketchydroide commented 2 years ago

still same

JmillsExpensify commented 2 years ago

Quick note that this is a WhatsApp Quality initiative, as standardizing these forms helps us get a handle on related bugs.

sketchydroide commented 2 years ago

This is under review, we will be reviewing the PR over the next days, @luacmartins is OOO this week, so hopefully we will have this done and merged next week

melvin-bot[bot] commented 2 years ago

@sketchydroide, @mananjadhav, @ravindra-encoresky, @adelekennedy Whoops! This issue is 2 days overdue. Let's get this updated quick!

mananjadhav commented 2 years ago

PR is reviewed, and I've left 1-2 comments. This should be closed very soon.

mountiny commented 2 years ago

PR is almost merged here.

JmillsExpensify commented 2 years ago

Working through the commits, but looks like we should be through those really soon, ideally in the coming day or two.

sketchydroide commented 2 years ago

this is now merged, there were some issue gettin the commits verified, but after creating a new PR this was fixed and everyine was happy

melvin-bot[bot] commented 2 years ago

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

sketchydroide commented 2 years ago

there was a deploy blocker associated, but that seems to have been fixed now

melvin-bot[bot] commented 2 years ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.2.34-1 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2022-12-08. :confetti_ball:

After the hold period, please check if any of the following need payment for this issue, and if so check them off after paying:

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

mananjadhav commented 1 year ago

@sketchydroide @luacmartins This is supposed to be paid out today, but before that I would like to request a raise for this one. This is was held for a long time for AddressForm, and went through multiple rounds for the review. Compared to average issues, this was a bit bigger.

luacmartins commented 1 year ago

@mananjadhav what price do you think is fair?

adelekennedy commented 1 year ago

pending payment on the discussion above

mananjadhav commented 1 year ago

I think 500$ should be fine here. Please note this also had a regression involved. So incase we don't want to increase then that is fine too.

ravindra-encoresky commented 1 year ago

I think 500$ should be fine here. Please note this also had a regression involved. So incase we don't want to increase then that is fine too.

I would go with the first option :) , it's been long back and forth. Thanks, looking forward.

luacmartins commented 1 year ago

$500 seems fair to me. Let's go with that.

mananjadhav commented 1 year ago

Thanks @luacmartins. @adelekennedy can you help with the payout here?

adelekennedy commented 1 year ago

@mananjadhav just hired you at $500

mananjadhav commented 1 year ago

Accepted @adelekennedy

adelekennedy commented 1 year ago

paid and paid!

ravindra-encoresky commented 1 year ago

@adelekennedy @mananjadhav I've received only $250.

JmillsExpensify commented 1 year ago

Re-opening until the contributor's question is answered.

mallenexpensify commented 1 year ago

Sorry about that @ravindra-encoresky , not sure what happened. I just bonused you $250 so total compensation is now $500. Double checked Manan's contract and the payment was $500 there, re-closing

ravindra-encoresky commented 1 year ago

Sorry about that @ravindra-encoresky , not sure what happened. I just bonused you $250 so total compensation is now $500. Double checked Manan's contract and the payment was $500 there, re-closing

Got it, thank you.