search

Expensify / Bedrock

Rock solid distributed database specializing in active/active automatic failover and WAN replication
https://bedrockdb.com
GNU Lesser General Public License v3.0
1.08k stars 82 forks source link

Update SQlite3 #1768

Closed johnmlee101 closed 2 months ago

johnmlee101 commented 2 months ago

Details

Fixes a conflict reporting issue

Fixed Issues

https://expensify.slack.com/archives/C0714QF3A1Z/p1717520747775969?thread_ts=1717512172.169249&cid=C0714QF3A1Z

Tests

Internal Testing Reminder: when changing bedrock, please compile auth against your new changes

johnmlee101 commented 2 months ago

ran

AMALGAMATION_FLAGS="$(grep 'AMALGAMATION_FLAGS = ' Bedrock/Makefile | awk -F= '{print $2}')"
CLI_FLAGS="-DHAVE_READLINE -O2"
./configure --enable-fts5 --enable-update-limit
make sqlite3.c shell.c
johnmlee101 commented 2 months ago

running over auth now

johnmlee101 commented 2 months ago

just realized the flags meant nothing in my run 😂 so 

./configure --enable-fts5 --enable-update-limit
make sqlite3.c shell.c

is all that matters

johnmlee101 commented 2 months ago 
✅ PayViaStripeConnectTest::testPaymentToSameAccount (2398ms)
Took 5871ms to stop cluster.

[ TEST RESULTS ] Passed: 3053, Failed: 0

Slowest Test Classes:
361532ms: PayViaStripeConnect
322550ms: WalletMTLFile
321930ms: WalletPayment
315760ms: WalletTransferBalance
314843ms: WalletCustomerMasterFile
314725ms: ValidateBankAccount
313587ms: UpgradeSharedBankAccounts
313573ms: WalletReimbursement
312855ms: ValidateBillingFund
310738ms: WalletLookupFile
./authtest -threads 16  490.45s user 94.57s system 161% cpu 6:02.09 total
johnmlee101 commented 2 months ago

all tests passed