Expensify / Bedrock

Rock solid distributed database specializing in active/active automatic failover and WAN replication
https://bedrockdb.com
GNU Lesser General Public License v3.0
1.08k stars 82 forks source link

Make SRandom::randStr() not require a reference #1786

Closed coleaeason closed 2 months ago

coleaeason commented 2 months ago

@tylerkaraszewski This updates SRandom::randStr() to not require a reference. I'm not sure why we originally implemented it this way (we being me). We have a bunch of code in Auth like this:

int64_t size = 123;
string rand = SRandom::randStr(size);

instead of being able to just do this:

string rand = SRandom::randStr(123):

Fixed Issues

Confusing code

Tests


Internal Testing Reminder: when changing bedrock, please compile auth against your new changes