Closed coleaeason closed 2 months ago
@tylerkaraszewski This updates SRandom::randStr() to not require a reference. I'm not sure why we originally implemented it this way (we being me). We have a bunch of code in Auth like this:
SRandom::randStr()
int64_t size = 123; string rand = SRandom::randStr(size);
instead of being able to just do this:
string rand = SRandom::randStr(123):
Confusing code
Internal Testing Reminder: when changing bedrock, please compile auth against your new changes
@tylerkaraszewski This updates
SRandom::randStr()
to not require a reference. I'm not sure why we originally implemented it this way (we being me). We have a bunch of code in Auth like this:instead of being able to just do this:
Fixed Issues
Confusing code
Tests
Internal Testing Reminder: when changing bedrock, please compile auth against your new changes