Closed tylerkaraszewski closed 1 month ago
Added test logs.
reverting this since it created flakey tests here: https://expensify.slack.com/archives/C07J32337/p1720694871685509
I will investigate next week.
hmmmm did not read that massive thread, but my guess is: before we were basically waiting for the fire&forget command to finish whenever we did another call to that bedrock instance, with this change we are not, so some tests expect some data to be set, but it is sometimes not because the fire&forget command runs/finishes after the test checks for it.
Yeah, that's basically the gist. We'll want to make sure our test suite is set beforehand, but the change itself should still be good
Details
It seems we don't close the sockets for fire and forget commands until after we finish the commands. Let's close them right after we send the response.
Fixed Issues
https://github.com/Expensify/Expensify/issues/411326
Tests
Internal Testing Reminder: when changing bedrock, please compile auth against your new changes