Closed QichenZhu closed 1 month ago
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅
I have read the CLA Document and I hereby sign the CLA
recheck
@QichenZhu Thanks for the PR!
I might be slightly biased by the length of the code changed but I lean more towards the other solution mentioned in the comment (i.e. switching to TextKit 1 mode earlier by accessing layoutManager
field in willMoveToWindow:
). This one is a bit shorter and thus easier to understand for me. Are there any other benefits in the current approach?
Thanks for your feedback!
I prefer the main solution because it's straightforward - the height changes after the switch, so I just recover it.
The alternative seems somewhat magical. Why does the timing of the switch matter?
Please correct me if I'm wrong. @tomekzaw @hungvu193
I prefer the main solution because it's straightforward - the height changes after the switch, so I just recover it.
I also agree with @QichenZhu at this point.
Details
The input is sometimes not scrollable on iOS.
Related Issues
$ https://github.com/Expensify/App/issues/41567 PROPOSAL: https://github.com/Expensify/App/issues/41567#issuecomment-2137792675
Manual Tests
Expected Result: User is able to scroll down the task description.
Linked PRs