perf: use one loop instead of three for getCachedCollection

[hurali97]

Details

This PR improves the getCachedCollection by using only one loop to do the job which was previously taking three loops.

Related Issues

https://github.com/Expensify/App/issues/41895

Automated Tests

Manual Tests

Author Checklist

• [X] I linked the correct issue in the ### Related Issues section above
• [X] I wrote clear testing steps that cover the changes made in this PR
  • [X] I added steps for local testing in the Tests section
  • [X] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• [X] I included screenshots or videos for tests on all platforms
• [X] I ran the tests on all platforms & verified they passed on:
  • [X] Android / native
  • [X] Android / Chrome
  • [X] iOS / native
  • [X] iOS / Safari
  • [X] MacOS / Chrome / Safari
  • [X] MacOS / Desktop
• [X] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• [X] I followed proper code patterns (see Reviewing the code)
  • [X] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • [X] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • [X] I verified that comments were added to code that is not self explanatory
  • [X] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • [X] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • [X] I verified the JSDocs style guidelines (in STYLE.md) were followed
• [X] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• [X] I followed the guidelines as stated in the Review Guidelines
• [X] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• [X] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• [X] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• [X] I verified that if a function's arguments changed that all usages have also been updated correctly
• [X] If a new component is created I verified that:
  • [X] A similar component doesn't exist in the codebase
  • [X] All props are defined accurately and each prop has a /** comment above it */
  • [X] The file is named correctly
  • [X] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • [X] The only data being stored in the state is data necessary for rendering and nothing else
  • [X] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
  • [X] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • [X] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • [X] All JSX used for rendering exists in the render method
  • [X] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• [X] If any new file was added I verified that:
  • [X] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• [X] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• [X] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• [X] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

https://github.com/Expensify/react-native-onyx/assets/47336142/a7c766d1-7b55-459f-9d51-9d1d37062e95

Android: mWeb Chrome

https://github.com/Expensify/react-native-onyx/assets/47336142/9227d869-8b9d-4fc2-a096-3c83bc26eda8

iOS: Native

https://github.com/Expensify/react-native-onyx/assets/47336142/e9a70e60-2d7c-42d2-a2a0-da5cfa3769fa

iOS: mWeb Safari

https://github.com/Expensify/react-native-onyx/assets/47336142/92b0924d-7576-410f-82a5-32b096a4ab45

MacOS: Chrome / Safari

https://github.com/Expensify/react-native-onyx/assets/47336142/08eda0d1-3ad1-445c-add9-f2fbc0c44f1c

MacOS: Desktop

https://github.com/Expensify/react-native-onyx/assets/47336142/e3a26833-38d0-40e7-a36d-61041822fd67

[github-actions[bot]]

🚀Published to npm in v2.0.38