Closed ikevin127 closed 3 months ago
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅
I have read the CLA Document and I hereby sign the CLA
@fabioh8010 I think I addressed all the change requests, and some extra docs UI/UX related things like paragraph spacing for better readability and the markdown deprecation warning template for better notice/visualisation of the deprecated HOC.
Please take a look when you get a chance and let me know if there's anything else you'd do / write differently.
🚀Published to npm in v2.0.45
Details
Based on this Slack 🧵 discussion, this PR is updating the docs to promote the usage of the
useOnyx
hook over thewithOnyx
HOC which is deprecated and should not be used anymore, except if absolutely necessary for example if using React class components where hooks cannot be used.cc @roryabraham @fabioh8010
Related Issues
GH_LINK
Automated Tests
Manual Tests
Author Checklist
### Related Issues
section aboveTests
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop