search

Expensify / react-native-qrcode-svg

A QR Code generator for React Native based on react-native-svg and node-qrcode.
MIT License
1.07k stars 217 forks source link

Remove build step from npm publish workflow #214

Closed luacmartins closed 2 months ago

luacmartins commented 2 months ago

Coming from the latest workflow run, the workflow is failing with:

npm error Missing script: "build"

The previous npmpublish.yml workflow only had the following steps:

  1. setup node
  2. npm ci
  3. npm test
  4. npm publish

So I'm removing the npm run build step since it doesn't seem like we need to bundle this lib. cc @Kicu

luacmartins commented 2 months ago

Workflow still failing with:

npm notice
npm error code ENEEDAUTH
npm error need auth This command requires you to be logged in to https://registry.npmjs.org/
npm error need auth You need to authorize this machine using `npm adduser`

npm error A complete log of this run can be found in: /home/runner/.npm/_logs/2024-09-23T01_04_41_569Z-debug-0.log
Error: Process completed with exit code 1.

@justinpersaud have we taken over this repo on NPM?

justinpersaud commented 2 months ago

@luacmartins not as far as I'm aware, don't think anyone said to do that

luacmartins commented 2 months ago

It seems like our workflow is failing because of npm authentication. Is there a way for us to take ownership on npm?