search

ExpensiveKoala / Fishing-Real

Minecraft Mod about fishing up live fish instead of items
MIT License
5 stars 1 forks source link

Compat issue with Quality Crops #27

Closed CanecaKun closed 4 months ago

CanecaKun commented 4 months ago

When both mods are installed, more frequently only quality crops "fish item" is fished instead of the proper fish entity (Mod does not work properly)

ExpensiveKoala commented 4 months ago

Are you using a datapack or compatability mod that adds compatibility with Quality Crops? There is no way to dynamically figure out which mob corresponds with a specific item, so using a datapack that adds this conversion is required. If making your own datapack, you'd make them like below.

{
  "input": {
    "item": "qualitycrops:cod_iron"
  },
  "result": {
    "id": "minecraft:cod"
  }
}

Alternatively, since it seems Quality Crops adds their iron/gold/diamond versions to both the fishing loot table and entity drops. You could simply override the fishing loot table or delete their fishing loot table override.

CanecaKun commented 4 months ago

Uhhh, i will have a look, but i do not know how to delete their loot table for fishing or how to structure the compat datapack you mentioned, i only use regular functions on datapacks and have no experience with mod configurations using datapacks, but i will try, thanks!

ExpensiveKoala commented 4 months ago

A few of the bigger modpacks that included my mod have data packs configuring it. You can download those modpacks and look through their data packs.

Also, I have a data pack for aquaculture compat that you can copy the structure of: https://www.curseforge.com/minecraft/customization/fishing-real-aquaculture-datapack

Feel free to comment on this issue again if you are running into trouble.