search

ExperiBass / esiJS

A simple Node module for EVE Onlines' ESI.
https://github.com/ExperiBass/esiJS
GNU General Public License v3.0
21 stars 10 forks source link

[BUG] Corporation Alliance History is setup wrong #26

Closed Tmktahu closed 6 months ago

Tmktahu commented 6 months ago

The corporation group has an entry for corporationHistory that seems to be set up wrong. https://github.com/ExperiBass/esiJS/blob/1465a2807cb6316b4bbcfe841cc72891ea721a23/src/corporation.js#L4-L19

The comment seems to acknowledge that this is meant to be for the corporation's alliance history, but it is named wrong and attempts to send a request to a corporations/${corporationID}/corporationhistory endpoint which doesn't exist.

I believe this may be a copy-paste error and needs to be updated to point at the /corporations/${corporationID}/alliancehistory/ ESI route instead.

ExperiBass commented 6 months ago

ah youre right, good catch uwu

ExperiBass commented 6 months ago

alright, published on npm uwu