search

Experience-Monks / ae-to-json

will export an After Effects project as a JSON object
MIT License
237 stars 26 forks source link

Separate index.js #4

Closed mikkoh closed 8 years ago

mikkoh commented 8 years ago

index.js currently has many functions baked into the scope of the main function.

This should be broken to separate modules and a build script should be written to browserify + transpile code.

See issue #3

mikkoh commented 8 years ago

I was attempting to work on this. Obviously splitting up index.js is very easy. However...

I ran into issues running after-effects to unit tests. The ae-to-json main function when requiring in other modules.

I then attempted to browserify ae-to-json and send to after-effects for unit testing but that was failing as the export still because all require statements were not scoped inside that main function.

Anyway sad... All work can be seen here: https://github.com/jam3/ae-to-json/tree/feature/split-up Attempted to then browserify `ae-to-json

mikkoh commented 8 years ago

I've figured out how to run tests with the after-effects module.

We can take a umd module build scope it to one function and call the built umd build function.

In order to do this I had to cat a header and footer to the umd build.

It can be reviewed here b79ad10ca9830bb508a9d576562b59418cea9de6