Closed noerw closed 8 years ago
Thanks for the PR!
This module already works in the browser, as well as most other modules that I write. :smile: You need a bundler like Browserify, Webpack, JSPM or Rollup,
If you aren't using a bundler, you can also grab a standalone version of this module with Browserify-CDN. e.g. https://www.brcdn.org/?module=audiobuffer-to-wav&version=1.0.0&standalone=audioBufferToWav
Or wzrd.in: https://wzrd.in/standalone/audiobuffer-to-wav@1.0.0
I'd recommend just using a bundler, though.
There's a few reasons I don't support UMD and <script>
tags in my modules:
typepof
check and UMD boilerplate is error-prone and may cause issues in various environments; it's better to let the tools do it for us.Cheers! :sparkles:
Suggestion: add those links in the readme? Would use npm whenever avaialable, but jsfiddle and Codepen don't have them, and requirebin doesn't support es6 or even css for reproducible bug reports or standalone demos
One is more flexible with a bundler tool. I just like the simplicity of just including a script, without the need for extra tools, especially for small projects.
Mentioning these bundler tools in the readme indeed would be useful
The script can be natively used in the browser now. Thanks for putting this together :)